Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py

Issue 2415543004: Download the hermetic xcode toolchain on all bots that target mac. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py
diff --git a/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py b/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py
index abb3423be0e89bbab6896fc71a28c42b65c6d57d..6e0c29d6e223dcbf9b6817e5eac4efe2b8f3826d 100644
--- a/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py
+++ b/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py
@@ -42,7 +42,6 @@ SPEC = {
'chromium_apply_config': [
'chromium_mac_mac_views',
'mb',
- 'force_mac_toolchain'
],
'chromium_config_kwargs': {
'BUILD_CONFIG': 'Release',
@@ -55,7 +54,7 @@ SPEC = {
},
'Chromium Mac 10.11': {
'chromium_config': 'chromium',
- 'chromium_apply_config': ['mb', 'force_mac_toolchain'],
+ 'chromium_apply_config': ['mb'],
'gclient_config': 'chromium',
'chromium_config_kwargs': {
'BUILD_CONFIG': 'Release',
@@ -67,7 +66,7 @@ SPEC = {
},
'Chromium Mac 10.11 Force Mac Toolchain': {
'chromium_config': 'chromium',
- 'chromium_apply_config': ['mb', 'force_mac_toolchain'],
+ 'chromium_apply_config': ['mb'],
'gclient_config': 'chromium',
'chromium_config_kwargs': {
'BUILD_CONFIG': 'Release',
@@ -252,7 +251,6 @@ SPEC = {
'Print Preview Mac': {
'chromium_config': 'chromium',
'gclient_config': 'chromium',
- 'chromium_apply_config': ['force_mac_toolchain'],
'GYP_DEFINES': {
'component': 'shared_library',
},
@@ -401,7 +399,6 @@ SPEC = {
'Mac OpenSSL': {
'chromium_config': 'chromium',
'gclient_config': 'chromium',
- 'chromium_apply_config': ['force_mac_toolchain'],
'chromium_config_kwargs': {
'BUILD_CONFIG': 'Release',
'TARGET_BITS': 32,
@@ -1125,7 +1122,7 @@ SPEC = {
},
'Chromium Mac 10.9 Goma Canary': {
'chromium_config': 'chromium',
- 'chromium_apply_config': ['goma_canary', 'mb', 'force_mac_toolchain'],
+ 'chromium_apply_config': ['goma_canary', 'mb'],
'gclient_config': 'chromium',
'chromium_config_kwargs': {
'BUILD_CONFIG': 'Release',
@@ -1140,7 +1137,7 @@ SPEC = {
},
'Chromium Mac 10.9 Goma Canary (dbg)': {
'chromium_config': 'chromium',
- 'chromium_apply_config': ['goma_canary', 'mb', 'force_mac_toolchain'],
+ 'chromium_apply_config': ['goma_canary', 'mb'],
'gclient_config': 'chromium',
'chromium_config_kwargs': {
'BUILD_CONFIG': 'Debug',
@@ -1159,7 +1156,6 @@ SPEC = {
'clobber',
'goma_canary',
'mb',
- 'force_mac_toolchain',
],
'gclient_config': 'chromium',
'chromium_config_kwargs': {
@@ -1179,7 +1175,6 @@ SPEC = {
'clobber',
'goma_canary',
'mb',
- 'force_mac_toolchain',
],
'gclient_config': 'chromium',
'chromium_config_kwargs': {

Powered by Google App Engine
This is Rietveld 408576698