Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: scripts/slave/recipe_modules/chromium/config.py

Issue 2415543004: Download the hermetic xcode toolchain on all bots that target mac. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/chromium_tests/chromium_chrome.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/chromium/config.py
diff --git a/scripts/slave/recipe_modules/chromium/config.py b/scripts/slave/recipe_modules/chromium/config.py
index 376eebd7c3b60904b5f174b66dcb1c2abdd5f63e..9a65c523d09f5c9e7df3abbb6d5366746507ff1d 100644
--- a/scripts/slave/recipe_modules/chromium/config.py
+++ b/scripts/slave/recipe_modules/chromium/config.py
@@ -187,6 +187,9 @@ def BASE(c):
if gyp_arch:
c.gyp_env.GYP_DEFINES['target_arch'] = gyp_arch
+ if c.TARGET_PLATFORM == 'mac':
+ c.env.FORCE_MAC_TOOLCHAIN = 1
+
if c.BUILD_CONFIG in ['Coverage', 'Release']:
# The 'Coverage' target is not explicitly used by Chrome, but by some other
# projects in the Chrome ecosystem (ie: Syzygy).
@@ -803,8 +806,3 @@ def internal_gles2_conform_tests(c):
@config_ctx()
def build_angle_deqp_tests(c):
c.gyp_env.GYP_DEFINES['build_angle_deqp_tests'] = 1
-
-@config_ctx()
-def force_mac_toolchain(c):
- c.env.FORCE_MAC_TOOLCHAIN = 1
- c.gyp_env.FORCE_MAC_TOOLCHAIN = 1
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/chromium_tests/chromium_chrome.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698