Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Issue 2415533003: [wasm] Rename WasmModuleInstance to WasmInstance. (Closed)

Created:
4 years, 2 months ago by titzer
Modified:
4 years, 2 months ago
Reviewers:
Clemens Hammacher
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Rename WasmModuleInstance to WasmInstance. R=clemensh@chromium.org BUG= Committed: https://crrev.com/34459d50a685b2031bde57b9ea1217da96d1fc2c Cr-Commit-Position: refs/heads/master@{#40224}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M src/wasm/wasm-interpreter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/wasm/wasm-interpreter.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M src/wasm/wasm-module.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/wasm/wasm-module.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 2 chunks +2 lines, -2 lines 0 comments Download
M test/common/wasm/wasm-module-runner.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
titzer
4 years, 2 months ago (2016-10-12 12:58:45 UTC) #1
Clemens Hammacher
lgtm
4 years, 2 months ago (2016-10-12 13:10:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2415533003/1
4 years, 2 months ago (2016-10-12 13:52:28 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 13:57:10 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 13:57:33 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34459d50a685b2031bde57b9ea1217da96d1fc2c
Cr-Commit-Position: refs/heads/master@{#40224}

Powered by Google App Engine
This is Rietveld 408576698