Use ChannelMojo in CloudPrintProxyPolicyStartupTest.StartAndShutdown.

Use ChannelMojo in CloudPrintProxyPolicyStartupTest.StartAndShutdown.

CloudPrintProxyPolicyStartupTest.StartAndShutdown creates a second
channel between the main process and the service process for controlling
it during testing; this CL changes that channel to use ChannelMojo.

BUG=604282
Committed: https://crrev.com/75e57f805bc16308bccfc2f49a0c4b8b942283b9
Cr-Commit-Position: refs/heads/master@{#424804}

[Sam McNally, 2016-10-12 04:18:41]

Description was changed from

==========
Use ChannelMojo in CloudPrintProxyPolicyStartupTest.StartAndShutdown.

CloudPrintProxyPolicyStartupTest.StartAndShutdown creates a second
channel between the main process and the service process for controlling
;t during testing; This CL changes that channel to use ChannelMojo.

BUG=604282
==========

to

==========
Use ChannelMojo in CloudPrintProxyPolicyStartupTest.StartAndShutdown.

CloudPrintProxyPolicyStartupTest.StartAndShutdown creates a second
channel between the main process and the service process for controlling
it during testing; This CL changes that channel to use ChannelMojo.

BUG=604282
==========

[Sam McNally, 2016-10-12 04:18:50]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[Sam McNally, 2016-10-12 04:19:06]

Description was changed from

==========
Use ChannelMojo in CloudPrintProxyPolicyStartupTest.StartAndShutdown.

CloudPrintProxyPolicyStartupTest.StartAndShutdown creates a second
channel between the main process and the service process for controlling
it during testing; This CL changes that channel to use ChannelMojo.

BUG=604282
==========

to

==========
Use ChannelMojo in CloudPrintProxyPolicyStartupTest.StartAndShutdown.

CloudPrintProxyPolicyStartupTest.StartAndShutdown creates a second
channel between the main process and the service process for controlling
it during testing; this CL changes that channel to use ChannelMojo.

BUG=604282
==========

[commit-bot: I haz the power, 2016-10-12 04:19:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 05:11:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 05:11:09]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-10-12 06:17:58]

Patchset #1 (id:1) has been deleted

[Sam McNally, 2016-10-12 06:19:21]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 06:19:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-10-12 06:22:27]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 06:22:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 07:08:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 07:08:32]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-10-12 07:15:42]

Patchset #1 (id:20001) has been deleted

[Sam McNally, 2016-10-12 07:16:17]

sammc@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2016-10-12 07:34:54]

thestig@chromium.org changed reviewers:
+ rockot@chromium.org

[Lei Zhang, 2016-10-12 07:34:54]

Looks ok, but I haven't been doing much Mojo work, so adding rockot@ for a look
as well.

https://codereview.chromium.org/2415503002/diff/40001/chrome/browser/printing...
File
chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc
(right):

https://codereview.chromium.org/2415503002/diff/40001/chrome/browser/printing...
chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc:292:
startup_channel = IPC::ChannelProxy::Create(
Can this be combined with the previous line?

[Sam McNally, 2016-10-12 08:24:17]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 08:24:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-10-12 08:25:48]

https://codereview.chromium.org/2415503002/diff/40001/chrome/browser/printing...
File
chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc
(right):

https://codereview.chromium.org/2415503002/diff/40001/chrome/browser/printing...
chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc:292:
startup_channel = IPC::ChannelProxy::Create(
On 2016/10/12 07:34:54, Lei Zhang wrote:
> Can this be combined with the previous line?

Done.

[commit-bot: I haz the power, 2016-10-12 09:12:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 09:12:36]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2016-10-12 17:26:44]

lgtm

[Lei Zhang, 2016-10-12 17:28:42]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-10-12 17:29:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 17:35:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 17:35:21]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Lei Zhang, 2016-10-12 18:35:59]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2016-10-12 18:36:00]

lgtm

[commit-bot: I haz the power, 2016-10-12 18:36:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 18:44:44]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-10-12 18:49:05]

Description was changed from

==========
Use ChannelMojo in CloudPrintProxyPolicyStartupTest.StartAndShutdown.

CloudPrintProxyPolicyStartupTest.StartAndShutdown creates a second
channel between the main process and the service process for controlling
it during testing; this CL changes that channel to use ChannelMojo.

BUG=604282
==========

to

==========
Use ChannelMojo in CloudPrintProxyPolicyStartupTest.StartAndShutdown.

CloudPrintProxyPolicyStartupTest.StartAndShutdown creates a second
channel between the main process and the service process for controlling
it during testing; this CL changes that channel to use ChannelMojo.

BUG=604282

Committed: https://crrev.com/75e57f805bc16308bccfc2f49a0c4b8b942283b9
Cr-Commit-Position: refs/heads/master@{#424804}
==========

[commit-bot: I haz the power, 2016-10-12 18:49:06]

Patchset 2 (id:??) landed as
https://crrev.com/75e57f805bc16308bccfc2f49a0c4b8b942283b9
Cr-Commit-Position: refs/heads/master@{#424804}