Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2415483002: Check for more undefined behavior in CPDF_PSEngine. (Closed)

Created:
4 years, 2 months ago by Lei Zhang
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Check for more undefined behavior in CPDF_PSEngine. BUG=chromium:639792 Committed: https://pdfium.googlesource.com/pdfium/+/8bc9b8b2ddeb3ffa904d8f35039550c55706ba86

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : ValueOrDefault #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -9 lines) Patch
M core/fpdfapi/page/fpdf_page_func.cpp View 1 2 3 chunks +23 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Lei Zhang
4 years, 2 months ago (2016-10-12 01:17:07 UTC) #4
Tom Sepez
https://codereview.chromium.org/2415483002/diff/1/core/fpdfapi/page/fpdf_page_func.cpp File core/fpdfapi/page/fpdf_page_func.cpp (right): https://codereview.chromium.org/2415483002/diff/1/core/fpdfapi/page/fpdf_page_func.cpp#newcode215 core/fpdfapi/page/fpdf_page_func.cpp:215: } else { nit: ValueOrDefault(0)
4 years, 2 months ago (2016-10-12 16:08:42 UTC) #7
Tom Sepez
LGTM % nit
4 years, 2 months ago (2016-10-12 16:08:59 UTC) #8
Lei Zhang
https://codereview.chromium.org/2415483002/diff/1/core/fpdfapi/page/fpdf_page_func.cpp File core/fpdfapi/page/fpdf_page_func.cpp (right): https://codereview.chromium.org/2415483002/diff/1/core/fpdfapi/page/fpdf_page_func.cpp#newcode215 core/fpdfapi/page/fpdf_page_func.cpp:215: } else { On 2016/10/12 16:08:42, Tom Sepez wrote: ...
4 years, 2 months ago (2016-10-12 16:47:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2415483002/40001
4 years, 2 months ago (2016-10-12 16:47:44 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 16:59:38 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/8bc9b8b2ddeb3ffa904d8f35039550c55706...

Powered by Google App Engine
This is Rietveld 408576698