Query API: Introduces an OfflinePageModelQuery object.

components/offline_pages/client_policy_controller.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_OFFLINE_PAGES_CLIENT_POLICY_CONTROLLER_H_
 #define COMPONENTS_OFFLINE_PAGES_CLIENT_POLICY_CONTROLLER_H_
 
 #include <stdint.h>
 
 #include <map>
@@ skipping 17 matching lines @@
   static const OfflinePageClientPolicy MakePolicy(
       const std::string& name_space,
       LifetimePolicy::LifetimeType lifetime_type,
       const base::TimeDelta& expiration_period,
       size_t page_limit,
       size_t pages_allowed_per_url);
 
   // Get the client policy for |name_space|.
   const OfflinePageClientPolicy& GetPolicy(const std::string& name_space) const;
 
+  // Returns a list of all known namespaces.
+  std::vector<std::string> GetAllNamespaces() const;
+
   // Returns whether pages for |name_space| should be removed on cache reset.
   bool IsRemovedOnCacheReset(const std::string& name_space) const;
 
   // Returns whether pages for |name_space| are shown in Download UI.
   bool IsSupportedByDownload(const std::string& name_space) const;
   const std::vector<std::string>& GetNamespacesSupportedByDownload() const;
 
   // Returns whether pages for |name_space| are shown in recent tabs UI,
   // currently only available on NTP.
   bool IsShownAsRecentlyVisitedSite(const std::string& name_space) const;
   const std::vector<std::string>& GetNamespacesShownAsRecentlyVisitedSite()
       const;
 
   // Returns whether pages for |name_space| should never be shown outside the
   // tab they were generated in.
   bool IsRestrictedToOriginalTab(const std::string& name_space) const;
   const std::vector<std::string>& GetNamespacesRestrictedToOriginalTab() const;
 
+  void AddPolicyForTest(std::string name_space,

[fgorski, 2016/10/26 18:05:41]

why not const ref ?

[dewittj, 2016/10/27 22:49:17]

Done.

In my experience, strings were not required to be const ref.  However, that is
just a memory and definitely deviates from common style in this file.

+                        const OfflinePageClientPolicyBuilder& builder);
+
  private:
   // The map from name_space to a client policy. Will be generated
   // as pre-defined values for now.
   std::map<std::string, OfflinePageClientPolicy> policies_;
 
   // Memoizing results.
   mutable std::unique_ptr<std::vector<std::string>> download_namespace_cache_;
   mutable std::unique_ptr<std::vector<std::string>> recent_tab_namespace_cache_;
   mutable std::unique_ptr<std::vector<std::string>> show_in_original_tab_cache_;
 
   DISALLOW_COPY_AND_ASSIGN(ClientPolicyController);
 };
 
 }  // namespace offline_pages
 
 #endif  // COMPONENTS_OFFLINE_PAGES_CLIENT_POLICY_CONTROLLER_H_