Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5809)

Unified Diff: chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm

Issue 2415453004: [Mac] Don't show tooltip when zoom decoration is hidden. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm
diff --git a/chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm b/chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm
index 992baaeb3cd70d22d8c2218d850c2d6cd9ad396a..2bdc753e136e078db4e682a9ff4a1b9269a4f7e0 100644
--- a/chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm
+++ b/chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm
@@ -104,7 +104,9 @@ void ZoomDecoration::ShowAndUpdateUI(zoom::ZoomController* zoom_controller,
SetImage(GetMaterialIcon(location_bar_is_dark));
- tooltip_.reset([tooltip_string retain]);
+ tooltip_.reset(vector_icon_id_ == gfx::VectorIconId::VECTOR_ICON_NONE
Avi (use Gerrit) 2016/10/12 19:40:10 It's equivalent, but it feels better to do: toolt
shrike 2016/10/12 20:43:36 I like checking the icon id because it's explicit
+ ? @""
+ : [tooltip_string retain]);
SetVisible(true);
[bubble_ onZoomChanged];
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698