Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2415423002: Added a ForceYouTubeRestrict policy and deprecated the old ForceYouTubeSafetyMode policy (Closed)

Created:
4 years, 2 months ago by Thiemo Nagel
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Added a ForceYouTubeRestrict policy and deprecated the old ForceYouTubeSafetyMode policy ForceYouTubeRestrict allows 3 settings: off/moderate/strict. ForceYouTubeSafetyMode only allowed off/on. If ForceYouTubeRestrict is set, ForceYouTubeSafetyMode is ignored. If ForceYouTubeRestrict is not set and ForceYouTubeSafetyMode is set, 'on' is mapped to 'moderate'. If the deprecated ForceSafeSearch policy is set and neither ForceYouTubeSafetyMode nor ForceYouTubeRestrict are set, 'on' is mapped to 'moderate' as well. The restrict mode is sent to YouTube by adding a "YouTube-Restrict" HTML request header with values "Moderate" resp. "Strict". The old "YouTube-Safety-Mode" is no longer sent, even if ForceYouTubeRestrict is not set. YouTube already properly interprets "YouTube-Restrict". BUG=590478 Review-Url: https://codereview.chromium.org/2239753002 Cr-Commit-Position: refs/heads/master@{#423571} (cherry picked from commit c42c0dddcb3c630cb30096d16a4485bd1025eccc) Committed: https://chromium.googlesource.com/chromium/src/+/8fa312f6c8be200caf342c8cb26f7e638b62b5a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+374 lines, -162 lines) Patch
M chrome/browser/net/chrome_network_delegate.h View 6 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 8 chunks +23 lines, -17 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate_unittest.cc View 4 chunks +20 lines, -19 lines 0 comments Download
M chrome/browser/net/safe_search_util.h View 1 chunk +22 lines, -6 lines 0 comments Download
M chrome/browser/net/safe_search_util.cc View 3 chunks +28 lines, -14 lines 0 comments Download
M chrome/browser/net/safe_search_util_unittest.cc View 1 chunk +13 lines, -10 lines 0 comments Download
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 5 chunks +53 lines, -8 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 2 chunks +77 lines, -26 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_pref_store.cc View 4 chunks +30 lines, -16 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_pref_store_unittest.cc View 4 chunks +12 lines, -10 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_service_browsertest.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/test/data/policy/policy_test_cases.json View 2 chunks +11 lines, -4 lines 0 comments Download
M components/policy/resources/policy_templates.json View 3 chunks +57 lines, -9 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Thiemo Nagel
4 years, 2 months ago (2016-10-14 12:22:31 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8fa312f6c8be200caf342c8cb26f7e638b62b5a5.

Powered by Google App Engine
This is Rietveld 408576698