Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Issue 2415413003: Remove unused method and field from DartSdkManager (Closed)

Created:
4 years, 2 months ago by Brian Wilkerson
Modified:
4 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -85 lines) Patch
M pkg/analysis_server/lib/src/server/driver.dart View 3 chunks +11 lines, -11 lines 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/analysis_server_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 5 chunks +6 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/domain_diagnostic_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/domain_execution_test.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/analysis_server/test/domain_server_test.dart View 2 chunks +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/single_context_manager_test.dart View 2 chunks +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/socket_server_test.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk.dart View 4 chunks +4 lines, -28 lines 0 comments Download
M pkg/analyzer/test/generated/sdk_test.dart View 4 chunks +3 lines, -11 lines 0 comments Download
M pkg/analyzer/test/src/context/builder_test.dart View 2 chunks +2 lines, -5 lines 0 comments Download
M pkg/analyzer/test/stress/for_git_repository.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 2 months ago (2016-10-14 16:47:40 UTC) #2
scheglov
LGTM
4 years, 2 months ago (2016-10-14 16:49:43 UTC) #3
Brian Wilkerson
4 years, 2 months ago (2016-10-14 16:53:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3155b1e08c2418992b4d24f32084d92e673712bd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698