Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 2415373002: Loading: bulk style errors fix in core/loader (Closed)

Created:
4 years, 2 months ago by Takashi Toyoshima
Modified:
4 years, 2 months ago
Reviewers:
kouhei (in TOK), dcheng
CC:
chromium-reviews, michaeln, tyoshino+watch_chromium.org, gavinp+prerender_chromium.org, Yoav Weiss, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, Nate Chapin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Loading: bulk style errors fix in core/loader There are many style errors probably after the cl-format changes indents. This may hide important presubmit warnings/errors in the middle of refactoring works. TEST=./Tools/Scripts/check-webkit-style Source/core/loader TEST=ninja -C out/Release all BUG=655920 Committed: https://crrev.com/34e1750b210d1e66183fcfd26fb0e72dc544cd5f Cr-Commit-Position: refs/heads/master@{#425271}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -79 lines) Patch
M third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp View 4 chunks +10 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FormSubmission.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 12 chunks +30 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp View 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 9 chunks +19 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/loader/HttpEquiv.cpp View 3 chunks +8 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/loader/ImageLoader.cpp View 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/LinkLoader.cpp View 5 chunks +12 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/MixedContentChecker.cpp View 6 chunks +12 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/loader/NavigationScheduler.cpp View 5 chunks +10 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/loader/PingLoader.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/PingLoaderTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/TextResourceDecoderBuilder.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/appcache/ApplicationCache.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/appcache/ApplicationCache.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/appcache/ApplicationCacheHost.cpp View 4 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Takashi Toyoshima
Can you take a look at this mechanical change?
4 years, 2 months ago (2016-10-14 06:18:24 UTC) #4
kouhei (in TOK)
+dcheng s/errros/errors/ lgtm.
4 years, 2 months ago (2016-10-14 06:28:31 UTC) #6
Takashi Toyoshima
thank you for catching errors on errors
4 years, 2 months ago (2016-10-14 06:32:37 UTC) #8
dcheng
LGTM Thanks for fixing these! Unfortunately, clang-format doesn't understand how to automatically insert / remove ...
4 years, 2 months ago (2016-10-14 06:40:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2415373002/1
4 years, 2 months ago (2016-10-14 08:00:18 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 08:06:23 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 08:08:23 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34e1750b210d1e66183fcfd26fb0e72dc544cd5f
Cr-Commit-Position: refs/heads/master@{#425271}

Powered by Google App Engine
This is Rietveld 408576698