Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 24153015: You get a rebaseline, and *you* get a rebaseline - everybody gets a lumamode rebaseline! (Closed)

Created:
7 years, 3 months ago by f(malita)
Modified:
7 years, 3 months ago
Reviewers:
epoger
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

You get a rebaseline, and *you* get a rebaseline - everybody gets a lumamode rebaseline! TBR=epoger Committed: https://code.google.com/p/skia/source/detail?r=11354

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M expectations/gm/Test-Android-IntelRhb-SGX544-x86-Release/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
f(malita)
Committed patchset #1 manually as r11354.
7 years, 3 months ago (2013-09-18 18:36:32 UTC) #1
epoger
LGTM Thanks for the fix. Sorry for the ugly process. It WILL get better soon, ...
7 years, 3 months ago (2013-09-18 18:37:58 UTC) #2
f(malita)
7 years, 3 months ago (2013-09-18 18:46:52 UTC) #3
Message was sent while issue was closed.
On 2013/09/18 18:37:58, epoger wrote:
> LGTM
> 
> Thanks for the fix.  Sorry for the ugly process.  It WILL get better soon, I
> promise.

Ah, no worries - if I understand correctly this was a dead bot that just came
up, no reason to blame the rebaseline tools.

Powered by Google App Engine
This is Rietveld 408576698