sdk/lib/_internal/compiler/implementation/resolution/members.dart - Issue 24153008: Check if signatures are compatible in a redirecting factory before synthesizing a call in the infer…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/resolution/members.dart

Issue 24153008: Check if signatures are compatible in a redirecting factory before synthesizing a call in the infer… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/elements/modelx.dart ('k') | sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/resolution/members.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/resolution/members.dart (revision 27593)

+++ sdk/lib/_internal/compiler/implementation/resolution/members.dart (working copy)

@@ -2653,7 +2653,8 @@

FunctionType targetType = redirectionTarget.computeType(compiler)

.subst(type.typeArguments, targetClass.typeVariables);

FunctionType constructorType = constructor.computeType(compiler);

- if (!compiler.types.isSubtype(targetType, constructorType)) {

+ bool isSubtype = compiler.types.isSubtype(targetType, constructorType);

+ if (!isSubtype) {

warning(node, MessageKind.NOT_ASSIGNABLE.warning,

{'fromType': targetType, 'toType': constructorType});

}

@@ -2663,6 +2664,7 @@

FunctionSignature constructorSignature =

constructor.computeSignature(compiler);

if (!targetSignature.isCompatibleWith(constructorSignature)) {

+ assert(!isSubtype);

compiler.backend.registerThrowNoSuchMethod(mapping);

}