Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1152)

Issue 2415293004: Mojo C++ Bindings: Make hashing of typemapped enums optional (Closed)

Created:
4 years, 2 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 2 months ago
Reviewers:
yzshen1, tibell
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ Bindings: Make hashing of typemapped enums optional This avoids the requirement to define std::hash<T> for a typemapped enum type used in mojom. BUG=None R=tibell@chromium.org TBR=yzshen@chromium.org Committed: https://crrev.com/0d24e8746d06cfb185af5eb54cdbaa557c311148 Cr-Commit-Position: refs/heads/master@{#425597}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M mojo/public/tools/bindings/generators/mojom_cpp_generator.py View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ken Rockot(use gerrit already)
4 years, 2 months ago (2016-10-15 15:35:09 UTC) #1
tibell
lgtm
4 years, 2 months ago (2016-10-16 21:26:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2415293004/1
4 years, 2 months ago (2016-10-16 21:36:38 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-16 22:29:04 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-16 22:30:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0d24e8746d06cfb185af5eb54cdbaa557c311148
Cr-Commit-Position: refs/heads/master@{#425597}

Powered by Google App Engine
This is Rietveld 408576698