Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/LayoutTests/storage/indexeddb/idbcursor-delete-exception-order.html

Issue 2415203002: Indexed DB: More exception precedence tests (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/LayoutTests/storage/indexeddb/idbcursor-advance-exception-order.html ('K') | « third_party/WebKit/LayoutTests/storage/indexeddb/idbcursor-continue-exception-order.html ('k') | third_party/WebKit/LayoutTests/storage/indexeddb/idbcursor-update-exception-order.html » ('j') | third_party/WebKit/LayoutTests/storage/indexeddb/idbcursor-update-exception-order.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/storage/indexeddb/idbcursor-delete-exception-order.html
diff --git a/third_party/WebKit/LayoutTests/storage/indexeddb/idbcursor-delete-exception-order.html b/third_party/WebKit/LayoutTests/storage/indexeddb/idbcursor-delete-exception-order.html
index fc04645f83647e5edba8035f371c1eee5717541a..ac78dd7756b1f91723864b3b71c306148b9d1f52 100644
--- a/third_party/WebKit/LayoutTests/storage/indexeddb/idbcursor-delete-exception-order.html
+++ b/third_party/WebKit/LayoutTests/storage/indexeddb/idbcursor-delete-exception-order.html
@@ -1,77 +1,77 @@
<!DOCTYPE html>
<title>IndexedDB: IDBCursor delete() Exception Ordering</title>
+<meta charset=utf-8>
<link rel="help" href="https://w3c.github.io/IndexedDB/#dom-idbcursor-delete">
<script src="../../resources/testharness.js"></script>
<script src="../../resources/testharnessreport.js"></script>
<script src="resources/testharness-helpers.js"></script>
-
<script>
indexeddb_test(
- function(t, db) {
- var s = db.createObjectStore('s');
- s.put('value', 'key');
- },
- function(t, db) {
- var s = db.transaction('s', 'readonly').objectStore('s');
- var r = s.openCursor();
- r.onsuccess = t.step_func(function() {
- r.onsuccess = null;
- var cursor = r.result;
- setTimeout(t.step_func(function() {
- assert_throws('TransactionInactiveError', function() {
- cursor.delete();
- }, '"Transaction inactive" check (TransactionInactivError) ' +
- 'should precede "read only" check (ReadOnlyError)');
- t.done();
- }), 0);
- });
- },
- 'IDBCursor.delete exception order: TransactionInactiveError vs. ReadOnlyError'
+ (t, db) => {
+ const s = db.createObjectStore('s');
+ s.put('value', 'key');
+ },
+ (t, db) => {
+ const s = db.transaction('s', 'readonly').objectStore('s');
+ const r = s.openCursor();
+ r.onsuccess = t.step_func(() => {
+ r.onsuccess = null;
+ const cursor = r.result;
+ setTimeout(t.step_func(() => {
+ assert_throws('TransactionInactiveError', () => {
+ cursor.delete();
+ }, '"Transaction inactive" check (TransactionInactivError) ' +
+ 'should precede "read only" check (ReadOnlyError)');
+ t.done();
+ }), 0);
+ });
+ },
+ 'IDBCursor.delete exception order: TransactionInactiveError vs. ReadOnlyError'
);
indexeddb_test(
- function(t, db) {
- var s = db.createObjectStore('s');
- s.put('value', 'key');
- },
- function(t, db) {
- var s = db.transaction('s', 'readonly').objectStore('s');
- var r = s.openCursor();
- r.onsuccess = t.step_func(function() {
- r.onsuccess = null;
- var cursor = r.result;
- cursor.continue();
- assert_throws('ReadOnlyError', function() {
- cursor.delete();
- }, '"Read only" check (ReadOnlyError) should precede ' +
- '"got value flag" (InvalidStateError) check');
- t.done();
- });
- },
- 'IDBCursor.delete exception order: ReadOnlyError vs. InvalidStateError #1'
+ (t, db) => {
+ const s = db.createObjectStore('s');
+ s.put('value', 'key');
+ },
+ (t, db) => {
+ const s = db.transaction('s', 'readonly').objectStore('s');
+ const r = s.openCursor();
+ r.onsuccess = t.step_func(() => {
+ r.onsuccess = null;
+ const cursor = r.result;
+ cursor.continue();
+ assert_throws('ReadOnlyError', () => {
+ cursor.delete();
+ }, '"Read only" check (ReadOnlyError) should precede ' +
+ '"got value flag" (InvalidStateError) check');
+ t.done();
+ });
+ },
+ 'IDBCursor.delete exception order: ReadOnlyError vs. InvalidStateError #1'
);
indexeddb_test(
- function(t, db) {
- var s = db.createObjectStore('s');
- s.put('value', 'key');
- },
- function(t, db) {
- var s = db.transaction('s', 'readonly').objectStore('s');
- var r = s.openKeyCursor();
- r.onsuccess = t.step_func(function() {
- r.onsuccess = null;
- var cursor = r.result;
- cursor.continue();
- assert_throws('ReadOnlyError', function() {
- cursor.delete();
- }, '"Read only" check (ReadOnlyError) should precede ' +
- '"key only flag" (InvalidStateError) check');
- t.done();
- });
- },
- 'IDBCursor.delete exception order: ReadOnlyError vs. InvalidStateError #2'
+ (t, db) => {
+ const s = db.createObjectStore('s');
+ s.put('value', 'key');
+ },
+ (t, db) => {
+ const s = db.transaction('s', 'readonly').objectStore('s');
+ const r = s.openKeyCursor();
+ r.onsuccess = t.step_func(() => {
+ r.onsuccess = null;
+ const cursor = r.result;
+ cursor.continue();
pwnall 2016/10/14 07:57:04 I think this continue() call will get you in the I
jsbell 2016/10/17 19:42:03 You're right! Removed.
+ assert_throws('ReadOnlyError', () => {
+ cursor.delete();
+ }, '"Read only" check (ReadOnlyError) should precede ' +
+ '"key only flag" (InvalidStateError) check');
+ t.done();
+ });
+ },
+ 'IDBCursor.delete exception order: ReadOnlyError vs. InvalidStateError #2'
);
</script>
« third_party/WebKit/LayoutTests/storage/indexeddb/idbcursor-advance-exception-order.html ('K') | « third_party/WebKit/LayoutTests/storage/indexeddb/idbcursor-continue-exception-order.html ('k') | third_party/WebKit/LayoutTests/storage/indexeddb/idbcursor-update-exception-order.html » ('j') | third_party/WebKit/LayoutTests/storage/indexeddb/idbcursor-update-exception-order.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698