Add infra_tests.py, recipe, buildbotless bot

Add infra_tests.py, recipe, buildbotless bot

Have the presubmit (upload) run infra_tests.py if anything in infra/ changed.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2415193002

Committed: https://skia.googlesource.com/skia/+/2dbbfa5d376d7356df5e18bd41d7138aa6345512

[borenet2, 2016-10-13 19:49:10]

Description was changed from

==========
Add infra_tests.py, recipe, task

BUG=skia:
==========

to

==========
Add infra_tests.py, recipe, task

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2415193002
==========

[borenet, 2016-10-13 20:26:24]

Description was changed from

==========
Add infra_tests.py, recipe, task

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2415193002
==========

to

==========
Add infra_tests.py, recipe, buildbotless bot

Have the presubmit (upload) run infra_tests.py if anything in infra/ changed.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2415193002
==========

[borenet, 2016-10-13 20:28:14]

borenet@google.com changed reviewers:
+ benjaminwagner@google.com, borenet@google.com, rmistry@google.com

[borenet, 2016-10-13 20:28:15]

Also fixed a UTC bug introduced in https://codereview.chromium.org/2398173002/

[dogben, 2016-10-13 23:37:03]

lgtm

LGTM; Ravi should probably skim through it also.

[rmistry, 2016-10-14 11:36:28]

https://codereview.chromium.org/2415193002/diff/100001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/2415193002/diff/100001/PRESUBMIT.py#newcode239
PRESUBMIT.py:239: results.extend(_InfraTests(input_api, output_api))
Soon we will also keep this in CheckChangeOnCommit ?

https://codereview.chromium.org/2415193002/diff/100001/infra/bots/infra_tests.py
File infra/bots/infra_tests.py (right):

https://codereview.chromium.org/2415193002/diff/100001/infra/bots/infra_tests...
infra/bots/infra_tests.py:18: os.path.dirname(os.path.abspath(__file__)))))
1. You already have os.path.abspath(__file__) I am not sure you need the outer
abspath.
2. os.path.join has a single entry and is not joining anything?

https://codereview.chromium.org/2415193002/diff/100001/infra/bots/infra_tests...
infra/bots/infra_tests.py:29: def python_tests():
maybe unit_tests or python_unit_tests is a better name here.

https://codereview.chromium.org/2415193002/diff/100001/infra/bots/recipe_modu...
File infra/bots/recipe_modules/vars/api.py (right):

https://codereview.chromium.org/2415193002/diff/100001/infra/bots/recipe_modu...
infra/bots/recipe_modules/vars/api.py:54: 'InfraTests' in self.builder_name)
This keeps getting larger. At some point we will need to extract into a util.

[borenet, 2016-10-14 13:03:46]

https://codereview.chromium.org/2415193002/diff/100001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/2415193002/diff/100001/PRESUBMIT.py#newcode239
PRESUBMIT.py:239: results.extend(_InfraTests(input_api, output_api))
On 2016/10/14 11:36:28, rmistry wrote:
> Soon we will also keep this in CheckChangeOnCommit ?

I'm not sure. I think we'll want to add the InfraTests bot to the CQ separately
in which case it'd be redundant here.

https://codereview.chromium.org/2415193002/diff/100001/infra/bots/infra_tests.py
File infra/bots/infra_tests.py (right):

https://codereview.chromium.org/2415193002/diff/100001/infra/bots/infra_tests...
infra/bots/infra_tests.py:18: os.path.dirname(os.path.abspath(__file__)))))
On 2016/10/14 11:36:28, rmistry wrote:
> 1. You already have os.path.abspath(__file__) I am not sure you need the outer
> abspath.
> 2. os.path.join has a single entry and is not joining anything?

Done.

https://codereview.chromium.org/2415193002/diff/100001/infra/bots/infra_tests...
infra/bots/infra_tests.py:29: def python_tests():
On 2016/10/14 11:36:28, rmistry wrote:
> maybe unit_tests or python_unit_tests is a better name here.

Done.

https://codereview.chromium.org/2415193002/diff/100001/infra/bots/recipe_modu...
File infra/bots/recipe_modules/vars/api.py (right):

https://codereview.chromium.org/2415193002/diff/100001/infra/bots/recipe_modu...
infra/bots/recipe_modules/vars/api.py:54: 'InfraTests' in self.builder_name)
On 2016/10/14 11:36:28, rmistry wrote:
> This keeps getting larger. At some point we will need to extract into a util.

Acknowledged.

[rmistry, 2016-10-14 13:05:46]

lgtm

https://codereview.chromium.org/2415193002/diff/100001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/2415193002/diff/100001/PRESUBMIT.py#newcode239
PRESUBMIT.py:239: results.extend(_InfraTests(input_api, output_api))
On 2016/10/14 13:03:46, borenet wrote:
> On 2016/10/14 11:36:28, rmistry wrote:
> > Soon we will also keep this in CheckChangeOnCommit ?
> 
> I'm not sure. I think we'll want to add the InfraTests bot to the CQ
separately
> in which case it'd be redundant here.

Yes, adding to CQ will be better.

[borenet, 2016-10-14 13:09:46]

The CQ bit was checked by borenet@google.com

[borenet, 2016-10-14 13:09:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
benjaminwagner@google.com
Link to the patchset: https://codereview.chromium.org/2415193002/#ps120001
(title: "Fixes")

[commit-bot: I haz the power, 2016-10-14 13:09:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 13:32:14]

Description was changed from

==========
Add infra_tests.py, recipe, buildbotless bot

Have the presubmit (upload) run infra_tests.py if anything in infra/ changed.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2415193002
==========

to

==========
Add infra_tests.py, recipe, buildbotless bot

Have the presubmit (upload) run infra_tests.py if anything in infra/ changed.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2415193002

Committed:
https://skia.googlesource.com/skia/+/2dbbfa5d376d7356df5e18bd41d7138aa6345512
==========

[commit-bot: I haz the power, 2016-10-14 13:32:15]

Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/2dbbfa5d376d7356df5e18bd41d7138aa6345512