Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 2415183003: S390: Change printf format specifier for promoted and semi_space_copied in GcTracer (Closed)

Created:
4 years, 2 months ago by yangtian.zi
Modified:
4 years, 2 months ago
Reviewers:
Michael Lippautz, ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, JoranSiu, john.yan, JaideepBajwa, michael_dawson, MTBrandyberry
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Change printf format specifier for promoted and semi_space_copied in GcTracer promoted and semi_space_copied are still int type, so it is needed to use V8PRIdPTR as their printf format specifier. R=mlippautz@chromium.org, ulan@chromium.org BUG= Committed: https://crrev.com/cb0958e6577e80c442ef826eb8fb75ebf21e72c2 Cr-Commit-Position: refs/heads/master@{#40317}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/heap/gc-tracer.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
yangtian.zi
ptal - sorry for the inconvenience.
4 years, 2 months ago (2016-10-13 19:26:29 UTC) #1
ulan
Thanks for fixing, lgtm.
4 years, 2 months ago (2016-10-14 08:12:23 UTC) #2
Michael Lippautz
lgtm ;)
4 years, 2 months ago (2016-10-14 09:33:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2415183003/1
4 years, 2 months ago (2016-10-14 13:19:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 13:46:02 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 13:46:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb0958e6577e80c442ef826eb8fb75ebf21e72c2
Cr-Commit-Position: refs/heads/master@{#40317}

Powered by Google App Engine
This is Rietveld 408576698