Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: src/builtins/builtins-object.cc

Issue 2415173003: Revert of [builtins] Also port the Object.prototype.__proto__ accessors to C++. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/builtins/builtins.h ('k') | src/js/v8natives.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/builtins/builtins.h" 5 #include "src/builtins/builtins.h"
6 #include "src/builtins/builtins-utils.h" 6 #include "src/builtins/builtins-utils.h"
7 7
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/property-descriptor.h" 9 #include "src/property-descriptor.h"
10 10
(...skipping 704 matching lines...) Expand 10 before | Expand all | Expand 10 after
715 // 4. Let status be ? O.[[SetPrototypeOf]](proto). 715 // 4. Let status be ? O.[[SetPrototypeOf]](proto).
716 // 5. If status is false, throw a TypeError exception. 716 // 5. If status is false, throw a TypeError exception.
717 MAYBE_RETURN( 717 MAYBE_RETURN(
718 JSReceiver::SetPrototype(receiver, proto, true, Object::THROW_ON_ERROR), 718 JSReceiver::SetPrototype(receiver, proto, true, Object::THROW_ON_ERROR),
719 isolate->heap()->exception()); 719 isolate->heap()->exception());
720 720
721 // 6. Return O. 721 // 6. Return O.
722 return *receiver; 722 return *receiver;
723 } 723 }
724 724
725 // ES6 section B.2.2.1.1 get Object.prototype.__proto__
726 BUILTIN(ObjectPrototypeGetProto) {
727 HandleScope scope(isolate);
728 // 1. Let O be ? ToObject(this value).
729 Handle<JSReceiver> receiver;
730 ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
731 isolate, receiver, Object::ToObject(isolate, args.receiver()));
732
733 // 2. Return ? O.[[GetPrototypeOf]]().
734 RETURN_RESULT_OR_FAILURE(isolate,
735 JSReceiver::GetPrototype(isolate, receiver));
736 }
737
738 // ES6 section B.2.2.1.2 set Object.prototype.__proto__
739 BUILTIN(ObjectPrototypeSetProto) {
740 HandleScope scope(isolate);
741 // 1. Let O be ? RequireObjectCoercible(this value).
742 Handle<Object> object = args.receiver();
743 if (object->IsNull(isolate) || object->IsUndefined(isolate)) {
744 THROW_NEW_ERROR_RETURN_FAILURE(
745 isolate, NewTypeError(MessageTemplate::kCalledOnNullOrUndefined,
746 isolate->factory()->NewStringFromAsciiChecked(
747 "set Object.prototype.__proto__")));
748 }
749
750 // 2. If Type(proto) is neither Object nor Null, return undefined.
751 Handle<Object> proto = args.at<Object>(1);
752 if (!proto->IsNull(isolate) && !proto->IsJSReceiver()) {
753 return isolate->heap()->undefined_value();
754 }
755
756 // 3. If Type(O) is not Object, return undefined.
757 if (!object->IsJSReceiver()) return isolate->heap()->undefined_value();
758 Handle<JSReceiver> receiver = Handle<JSReceiver>::cast(object);
759
760 // 4. Let status be ? O.[[SetPrototypeOf]](proto).
761 // 5. If status is false, throw a TypeError exception.
762 MAYBE_RETURN(
763 JSReceiver::SetPrototype(receiver, proto, true, Object::THROW_ON_ERROR),
764 isolate->heap()->exception());
765
766 // Return undefined.
767 return isolate->heap()->undefined_value();
768 }
769
770 // ES6 section 19.1.2.6 Object.getOwnPropertyDescriptor ( O, P ) 725 // ES6 section 19.1.2.6 Object.getOwnPropertyDescriptor ( O, P )
771 BUILTIN(ObjectGetOwnPropertyDescriptor) { 726 BUILTIN(ObjectGetOwnPropertyDescriptor) {
772 HandleScope scope(isolate); 727 HandleScope scope(isolate);
773 // 1. Let obj be ? ToObject(O). 728 // 1. Let obj be ? ToObject(O).
774 Handle<Object> object = args.atOrUndefined(isolate, 1); 729 Handle<Object> object = args.atOrUndefined(isolate, 1);
775 Handle<JSReceiver> receiver; 730 Handle<JSReceiver> receiver;
776 ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, receiver, 731 ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, receiver,
777 Object::ToObject(isolate, object)); 732 Object::ToObject(isolate, object));
778 // 2. Let key be ? ToPropertyKey(P). 733 // 2. Let key be ? ToPropertyKey(P).
779 Handle<Object> property = args.atOrUndefined(isolate, 2); 734 Handle<Object> property = args.atOrUndefined(isolate, 2);
(...skipping 233 matching lines...) Expand 10 before | Expand all | Expand 10 after
1013 typedef CompareDescriptor Descriptor; 968 typedef CompareDescriptor Descriptor;
1014 Node* object = assembler->Parameter(Descriptor::kLeft); 969 Node* object = assembler->Parameter(Descriptor::kLeft);
1015 Node* callable = assembler->Parameter(Descriptor::kRight); 970 Node* callable = assembler->Parameter(Descriptor::kRight);
1016 Node* context = assembler->Parameter(Descriptor::kContext); 971 Node* context = assembler->Parameter(Descriptor::kContext);
1017 972
1018 assembler->Return(assembler->InstanceOf(object, callable, context)); 973 assembler->Return(assembler->InstanceOf(object, callable, context));
1019 } 974 }
1020 975
1021 } // namespace internal 976 } // namespace internal
1022 } // namespace v8 977 } // namespace v8
OLDNEW
« no previous file with comments | « src/builtins/builtins.h ('k') | src/js/v8natives.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698