Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2415173003: Revert of [builtins] Also port the Object.prototype.__proto__ accessors to C++. (Closed)

Created:
4 years, 2 months ago by Michael Achenbach
Modified:
4 years, 2 months ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [builtins] Also port the Object.prototype.__proto__ accessors to C++. (patchset #1 id:1 of https://codereview.chromium.org/2417183002/ ) Reason for revert: [Sheriff] Speculative revert for webkit tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/10656 Was broken before, but this one test failure started with this CL: inspector/console/console-dir.htm All other errors stopped after another revert. See also: https://github.com/v8/v8/wiki/Blink-layout-tests Original issue's description: > [builtins] Also port the Object.prototype.__proto__ accessors to C++. > > These accessors also always call into C++ anyways, so there's no point > in having the JavaScript wrappers. > > R=yangguo@chromium.org > BUG=v8:5049 > > Committed: https://crrev.com/ede69cfabd790fe9f171b5d1f426ea0fc55e3c98 > Cr-Commit-Position: refs/heads/master@{#40298} TBR=yangguo@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5049 Committed: https://crrev.com/0b74984156441e43a41b83b3711f512f02c1e30d Cr-Commit-Position: refs/heads/master@{#40303}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -54 lines) Patch
M src/bootstrapper.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/builtins/builtins-object.cc View 1 chunk +0 lines, -45 lines 0 comments Download
M src/js/v8natives.js View 2 chunks +18 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [builtins] Also port the Object.prototype.__proto__ accessors to C++.
4 years, 2 months ago (2016-10-14 09:50:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2415173003/1
4 years, 2 months ago (2016-10-14 09:50:15 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 09:50:26 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 09:51:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b74984156441e43a41b83b3711f512f02c1e30d
Cr-Commit-Position: refs/heads/master@{#40303}

Powered by Google App Engine
This is Rietveld 408576698