Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2415133002: [stubs] Gets rid of the Smi(Add/Sub)WithOverflow macros. (Closed)

Created:
4 years, 2 months ago by epertoso
Modified:
4 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Gets rid of the Smi(Add/Sub)WithOverflow macros. This is done to introduce the correct bitcasts operator on the right nodes. R=bmeurer@chromium.org BUG= Committed: https://crrev.com/4897c357e7529221773048d3424f378b107866a2 Cr-Commit-Position: refs/heads/master@{#40294}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -26 lines) Patch
M src/builtins/builtins-number.cc View 4 chunks +10 lines, -4 lines 0 comments Download
M src/code-stub-assembler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/code-stub-assembler.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/code-stubs.cc View 8 chunks +20 lines, -8 lines 0 comments Download
M src/interpreter/interpreter.cc View 4 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
epertoso
4 years, 2 months ago (2016-10-13 15:31:24 UTC) #3
Benedikt Meurer
lgtm
4 years, 2 months ago (2016-10-14 03:22:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2415133002/1
4 years, 2 months ago (2016-10-14 08:00:53 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 08:11:11 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 08:11:42 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4897c357e7529221773048d3424f378b107866a2
Cr-Commit-Position: refs/heads/master@{#40294}

Powered by Google App Engine
This is Rietveld 408576698