Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Issue 241513002: Remove some dead code from bindings/ folder (Closed)

Created:
6 years, 8 months ago by Inactive
Modified:
6 years, 8 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), arv+blink, jsbell+bindings_chromium.org, sof, kouhei+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive
Visibility:
Public.

Description

Remove some dead code from bindings/ folder Remove some dead code from bindings/ folder. Several functions were defined but never used. R=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171902

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -43 lines) Patch
M Source/bindings/v8/DOMWrapperWorld.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/bindings/v8/DOMWrapperWorld.cpp View 2 chunks +0 lines, -12 lines 0 comments Download
M Source/bindings/v8/ScriptHeapSnapshot.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/v8/ScriptHeapSnapshot.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/bindings/v8/V8StringResource.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/bindings/v8/V8StringResource.cpp View 2 chunks +0 lines, -19 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
6 years, 8 months ago (2014-04-17 20:42:55 UTC) #1
haraken
LGTM
6 years, 8 months ago (2014-04-17 23:13:38 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 8 months ago (2014-04-17 23:15:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/241513002/1
6 years, 8 months ago (2014-04-17 23:15:38 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-17 23:27:53 UTC) #5
Message was sent while issue was closed.
Change committed as 171902

Powered by Google App Engine
This is Rietveld 408576698