Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 2415123002: TaskScheduler: Fix initial order of SchedulerWorkers on idle stack. (Closed)

Created:
4 years, 2 months ago by fdoray
Modified:
4 years, 2 months ago
Reviewers:
robliao, gab
CC:
chromium-reviews, gab+watch_chromium.org, robliao+watch_chromium.org, fdoray+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

TaskScheduler: Fix initial order of SchedulerWorkers on idle stack. With this CL, SchedulerWorkers are pushed to the idle stack in reverse order of index. This is nice for 2 reasons: - In chrome://tracing, we see that workers with low indexes start running tasks before workers with high indexes. - In chrome://tracing, if |Number of used workers| is less than |Max workers|, we see tracks for workers [0, Number of used workers - 1] rather than [Max workers - Number of used workers, Max workers - 1]. BUG=553459 Committed: https://crrev.com/ffe700619a9cffa614ed1424452cf1d7dba50206 Cr-Commit-Position: refs/heads/master@{#425167}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M base/task_scheduler/scheduler_worker_pool_impl.cc View 1 chunk +11 lines, -8 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
fdoray
PTAL
4 years, 2 months ago (2016-10-13 15:26:34 UTC) #2
robliao
lgtm
4 years, 2 months ago (2016-10-13 17:42:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2415123002/1
4 years, 2 months ago (2016-10-13 20:14:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 21:28:48 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ffe700619a9cffa614ed1424452cf1d7dba50206 Cr-Commit-Position: refs/heads/master@{#425167}
4 years, 2 months ago (2016-10-13 21:31:13 UTC) #8
gab
4 years, 2 months ago (2016-10-17 17:00:39 UTC) #10
Message was sent while issue was closed.
Sweet, lgtm

Powered by Google App Engine
This is Rietveld 408576698