Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Side by Side Diff: src/debug/mirrors.js

Issue 2415073003: [debug] [reland] Consistently use script from FrameMirror (Closed)
Patch Set: address comments and minor other fixes Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/inspector/debugger-script.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2012 the V8 project authors. All rights reserved. 1 // Copyright 2006-2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 (function(global, utils) { 5 (function(global, utils) {
6 "use strict"; 6 "use strict";
7 7
8 // ---------------------------------------------------------------------------- 8 // ----------------------------------------------------------------------------
9 // Imports 9 // Imports
10 10
(...skipping 1521 matching lines...) Expand 10 before | Expand all | Expand 10 after
1532 }; 1532 };
1533 1533
1534 1534
1535 PropertyMirror.prototype.value = function() { 1535 PropertyMirror.prototype.value = function() {
1536 return MakeMirror(this.value_, false); 1536 return MakeMirror(this.value_, false);
1537 }; 1537 };
1538 1538
1539 1539
1540 /** 1540 /**
1541 * Returns whether this property value is an exception. 1541 * Returns whether this property value is an exception.
1542 * @return {booolean} True if this property value is an exception 1542 * @return {boolean} True if this property value is an exception
1543 */ 1543 */
1544 PropertyMirror.prototype.isException = function() { 1544 PropertyMirror.prototype.isException = function() {
1545 return this.exception_ ? true : false; 1545 return this.exception_ ? true : false;
1546 }; 1546 };
1547 1547
1548 1548
1549 PropertyMirror.prototype.attributes = function() { 1549 PropertyMirror.prototype.attributes = function() {
1550 return %DebugPropertyAttributesFromDetails(this.details_); 1550 return %DebugPropertyAttributesFromDetails(this.details_);
1551 }; 1551 };
1552 1552
1553 1553
1554 PropertyMirror.prototype.propertyType = function() { 1554 PropertyMirror.prototype.propertyType = function() {
1555 return %DebugPropertyTypeFromDetails(this.details_); 1555 return %DebugPropertyTypeFromDetails(this.details_);
1556 }; 1556 };
1557 1557
1558 1558
1559 /** 1559 /**
1560 * Returns whether this property has a getter defined through __defineGetter__. 1560 * Returns whether this property has a getter defined through __defineGetter__.
1561 * @return {booolean} True if this property has a getter 1561 * @return {boolean} True if this property has a getter
1562 */ 1562 */
1563 PropertyMirror.prototype.hasGetter = function() { 1563 PropertyMirror.prototype.hasGetter = function() {
1564 return this.getter_ ? true : false; 1564 return this.getter_ ? true : false;
1565 }; 1565 };
1566 1566
1567 1567
1568 /** 1568 /**
1569 * Returns whether this property has a setter defined through __defineSetter__. 1569 * Returns whether this property has a setter defined through __defineSetter__.
1570 * @return {booolean} True if this property has a setter 1570 * @return {boolean} True if this property has a setter
1571 */ 1571 */
1572 PropertyMirror.prototype.hasSetter = function() { 1572 PropertyMirror.prototype.hasSetter = function() {
1573 return this.setter_ ? true : false; 1573 return this.setter_ ? true : false;
1574 }; 1574 };
1575 1575
1576 1576
1577 /** 1577 /**
1578 * Returns the getter for this property defined through __defineGetter__. 1578 * Returns the getter for this property defined through __defineGetter__.
1579 * @return {Mirror} FunctionMirror reflecting the getter function or 1579 * @return {Mirror} FunctionMirror reflecting the getter function or
1580 * UndefinedMirror if there is no getter for this property 1580 * UndefinedMirror if there is no getter for this property
(...skipping 1504 matching lines...) Expand 10 before | Expand all | Expand 10 after
3085 // Functions needed by the debugger runtime. 3085 // Functions needed by the debugger runtime.
3086 utils.InstallFunctions(utils, DONT_ENUM, [ 3086 utils.InstallFunctions(utils, DONT_ENUM, [
3087 "ClearMirrorCache", ClearMirrorCache 3087 "ClearMirrorCache", ClearMirrorCache
3088 ]); 3088 ]);
3089 3089
3090 // Export to debug.js 3090 // Export to debug.js
3091 utils.Export(function(to) { 3091 utils.Export(function(to) {
3092 to.MirrorType = MirrorType; 3092 to.MirrorType = MirrorType;
3093 }); 3093 });
3094 }) 3094 })
OLDNEW
« no previous file with comments | « no previous file | src/inspector/debugger-script.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698