Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 2415073002: [regexp] Fix fallback path in RegExpExec (Closed)

Created:
4 years, 2 months ago by jgruber
Modified:
4 years, 2 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Fix fallback path in RegExpExec This fixes the code-path in RegExpExec in which both the passed exec argument and regexp.exec are not callable and regexp is a JSRegExp. In this case, we fall back to the default RegExp.prototype.exec implementation. The arguments for Execution::call were incorrect. BUG=v8:5339 Committed: https://crrev.com/e89eef30293dbdd203c4d077e666b33bf87d21a3 Cr-Commit-Position: refs/heads/master@{#40249}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/regexp/regexp-utils.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regexp-regexpexec.js View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
jgruber
4 years, 2 months ago (2016-10-13 09:58:33 UTC) #4
Yang
On 2016/10/13 09:58:33, jgruber wrote: lgtm.
4 years, 2 months ago (2016-10-13 10:38:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2415073002/1
4 years, 2 months ago (2016-10-13 10:39:44 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 10:43:26 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 10:43:43 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e89eef30293dbdd203c4d077e666b33bf87d21a3
Cr-Commit-Position: refs/heads/master@{#40249}

Powered by Google App Engine
This is Rietveld 408576698