Revert of Minor improvements to MockLogDnsTraffic

Revert of Minor improvements to MockLogDnsTraffic (patchset #9 id:160001 of https://codereview.chromium.org/2348393002/ )

Reason for revert:
This broke a lot of LogDnsClientTest tests on all platforms:

https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/29988
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/47542
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/58536

Original issue's description:
> Improves documentation and formatting.
>
> Replaces some test ASSERT/EXPECT calls with DCHECK, as they would only be the result of incorrect test setup.
>
> Small refactorings to improve encapsulation.
>
> BUG=624894
>
> Committed: https://crrev.com/f02172072e3fd83e2296e984f1e5bd86ba40093c
> Cr-Commit-Position: refs/heads/master@{#424984}

TBR=eranm@chromium.org,rsleevi@chromium.org,robpercival@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=624894
Committed: https://crrev.com/edce9665b9672f51ac2709224798354c434c88e7
Cr-Commit-Position: refs/heads/master@{#424990}

[msramek, 2016-10-13 09:41:30]

The CQ bit was checked by msramek@chromium.org

[msramek, 2016-10-13 09:41:31]

Created Revert of Minor improvements to MockLogDnsTraffic

[commit-bot: I haz the power, 2016-10-13 09:41:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 09:42:44]

Description was changed from

==========
Revert of Minor improvements to MockLogDnsTraffic (patchset #9 id:160001 of
https://codereview.chromium.org/2348393002/ )

Reason for revert:
This broke a lot of LogDnsClientTest tests on all platforms:

https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/29988
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/47542
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/bui...

Original issue's description:
> Improves documentation and formatting.
> 
> Replaces some test ASSERT/EXPECT calls with DCHECK, as they would only be the
result of incorrect test setup.
> 
> Small refactorings to improve encapsulation.
> 
> BUG=624894
> 
> Committed: https://crrev.com/f02172072e3fd83e2296e984f1e5bd86ba40093c
> Cr-Commit-Position: refs/heads/master@{#424984}

TBR=eranm@chromium.org,rsleevi@chromium.org,robpercival@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=624894
==========

to

==========
Revert of Minor improvements to MockLogDnsTraffic (patchset #9 id:160001 of
https://codereview.chromium.org/2348393002/ )

Reason for revert:
This broke a lot of LogDnsClientTest tests on all platforms:

https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/29988
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/47542
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/bui...

Original issue's description:
> Improves documentation and formatting.
> 
> Replaces some test ASSERT/EXPECT calls with DCHECK, as they would only be the
result of incorrect test setup.
> 
> Small refactorings to improve encapsulation.
> 
> BUG=624894
> 
> Committed: https://crrev.com/f02172072e3fd83e2296e984f1e5bd86ba40093c
> Cr-Commit-Position: refs/heads/master@{#424984}

TBR=eranm@chromium.org,rsleevi@chromium.org,robpercival@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=624894
==========

[commit-bot: I haz the power, 2016-10-13 09:42:45]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-13 09:45:00]

Description was changed from

==========
Revert of Minor improvements to MockLogDnsTraffic (patchset #9 id:160001 of
https://codereview.chromium.org/2348393002/ )

Reason for revert:
This broke a lot of LogDnsClientTest tests on all platforms:

https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/29988
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/47542
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/bui...

Original issue's description:
> Improves documentation and formatting.
> 
> Replaces some test ASSERT/EXPECT calls with DCHECK, as they would only be the
result of incorrect test setup.
> 
> Small refactorings to improve encapsulation.
> 
> BUG=624894
> 
> Committed: https://crrev.com/f02172072e3fd83e2296e984f1e5bd86ba40093c
> Cr-Commit-Position: refs/heads/master@{#424984}

TBR=eranm@chromium.org,rsleevi@chromium.org,robpercival@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=624894
==========

to

==========
Revert of Minor improvements to MockLogDnsTraffic (patchset #9 id:160001 of
https://codereview.chromium.org/2348393002/ )

Reason for revert:
This broke a lot of LogDnsClientTest tests on all platforms:

https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/29988
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/47542
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/bui...

Original issue's description:
> Improves documentation and formatting.
>
> Replaces some test ASSERT/EXPECT calls with DCHECK, as they would only be the
result of incorrect test setup.
>
> Small refactorings to improve encapsulation.
>
> BUG=624894
>
> Committed: https://crrev.com/f02172072e3fd83e2296e984f1e5bd86ba40093c
> Cr-Commit-Position: refs/heads/master@{#424984}

TBR=eranm@chromium.org,rsleevi@chromium.org,robpercival@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=624894

Committed: https://crrev.com/edce9665b9672f51ac2709224798354c434c88e7
Cr-Commit-Position: refs/heads/master@{#424990}
==========

[commit-bot: I haz the power, 2016-10-13 09:45:02]

Patchset 1 (id:??) landed as
https://crrev.com/edce9665b9672f51ac2709224798354c434c88e7
Cr-Commit-Position: refs/heads/master@{#424990}