Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 2415053004: Some mirrors fixes (Closed)

Created:
4 years, 2 months ago by vsm
Modified:
4 years, 2 months ago
Reviewers:
Leaf
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Minor fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -11 lines) Patch
M pkg/dev_compiler/lib/js/amd/dart_sdk.js View 3 chunks +7 lines, -2 lines 0 comments Download
M pkg/dev_compiler/lib/js/common/dart_sdk.js View 3 chunks +7 lines, -2 lines 0 comments Download
M pkg/dev_compiler/lib/js/es6/dart_sdk.js View 3 chunks +7 lines, -2 lines 0 comments Download
M pkg/dev_compiler/lib/js/legacy/dart_sdk.js View 3 chunks +7 lines, -2 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart View 1 3 chunks +17 lines, -2 lines 0 comments Download
M pkg/dev_compiler/tool/sdk_expected_errors.txt View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
vsm
4 years, 2 months ago (2016-10-14 15:26:33 UTC) #2
Leaf
lgtm
4 years, 2 months ago (2016-10-14 15:53:51 UTC) #3
vsm
4 years, 2 months ago (2016-10-14 19:19:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
852ef37f71350bf4d37d883305e37730be43e942 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698