Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: src/runtime/runtime-internal.cc

Issue 2415023002: [promises] Move async debug event creation to c++ (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/runtime/runtime-debug.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/runtime/runtime-internal.cc
diff --git a/src/runtime/runtime-internal.cc b/src/runtime/runtime-internal.cc
index d4b71c5c6e547956694e28794c7fba9e738a82a8..5e171d622d16f166e86b4f6d3e23cfc1245d6dd6 100644
--- a/src/runtime/runtime-internal.cc
+++ b/src/runtime/runtime-internal.cc
@@ -577,12 +577,12 @@ RUNTIME_FUNCTION(Runtime_EnqueuePromiseReactionJob) {
CONVERT_ARG_HANDLE_CHECKED(Object, value, 0);
CONVERT_ARG_HANDLE_CHECKED(Object, tasks, 1);
CONVERT_ARG_HANDLE_CHECKED(Object, deferred, 2);
- CONVERT_ARG_HANDLE_CHECKED(Object, before_debug_event, 3);
- CONVERT_ARG_HANDLE_CHECKED(Object, after_debug_event, 4);
+ CONVERT_ARG_HANDLE_CHECKED(Object, debug_id, 3);
+ CONVERT_ARG_HANDLE_CHECKED(Object, debug_name, 4);
Handle<PromiseReactionJobInfo> info =
- isolate->factory()->NewPromiseReactionJobInfo(
- value, tasks, deferred, before_debug_event, after_debug_event,
- isolate->native_context());
+ isolate->factory()->NewPromiseReactionJobInfo(value, tasks, deferred,
+ debug_id, debug_name,
+ isolate->native_context());
isolate->EnqueueMicrotask(info);
return isolate->heap()->undefined_value();
}
@@ -594,12 +594,11 @@ RUNTIME_FUNCTION(Runtime_EnqueuePromiseResolveThenableJob) {
CONVERT_ARG_HANDLE_CHECKED(JSReceiver, then, 1);
CONVERT_ARG_HANDLE_CHECKED(JSFunction, resolve, 2);
CONVERT_ARG_HANDLE_CHECKED(JSFunction, reject, 3);
- CONVERT_ARG_HANDLE_CHECKED(Object, before_debug_event, 4);
- CONVERT_ARG_HANDLE_CHECKED(Object, after_debug_event, 5);
+ CONVERT_ARG_HANDLE_CHECKED(Object, debug_id, 4);
+ CONVERT_ARG_HANDLE_CHECKED(Object, debug_name, 5);
Handle<PromiseResolveThenableJobInfo> info =
isolate->factory()->NewPromiseResolveThenableJobInfo(
- resolution, then, resolve, reject, before_debug_event,
- after_debug_event);
+ resolution, then, resolve, reject, debug_id, debug_name);
isolate->EnqueueMicrotask(info);
return isolate->heap()->undefined_value();
}
« no previous file with comments | « src/runtime/runtime-debug.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698