Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: src/objects-debug.cc

Issue 2415023002: [promises] Move async debug event creation to c++ (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.h ('k') | src/objects-inl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects-debug.cc
diff --git a/src/objects-debug.cc b/src/objects-debug.cc
index 3b233024e63ffdcf3cf0b23987bf335b9c897e5a..1f2b2fb6de056f19f8f11c449a0888065ba53db6 100644
--- a/src/objects-debug.cc
+++ b/src/objects-debug.cc
@@ -922,10 +922,8 @@ void PromiseResolveThenableJobInfo::PromiseResolveThenableJobInfoVerify() {
CHECK(then()->IsJSReceiver());
CHECK(resolve()->IsJSFunction());
CHECK(reject()->IsJSFunction());
- CHECK(before_debug_event()->IsJSObject() ||
- before_debug_event()->IsUndefined(isolate));
- CHECK(after_debug_event()->IsJSObject() ||
- after_debug_event()->IsUndefined(isolate));
+ CHECK(debug_id()->IsNumber() || debug_id()->IsUndefined(isolate));
+ CHECK(debug_name()->IsString() || debug_name()->IsUndefined(isolate));
}
void PromiseReactionJobInfo::PromiseReactionJobInfoVerify() {
@@ -934,10 +932,8 @@ void PromiseReactionJobInfo::PromiseReactionJobInfoVerify() {
CHECK(value()->IsObject());
CHECK(tasks()->IsJSArray() || tasks()->IsCallable());
CHECK(deferred()->IsJSObject() || deferred()->IsUndefined(isolate));
- CHECK(before_debug_event()->IsJSObject() ||
- before_debug_event()->IsUndefined(isolate));
- CHECK(after_debug_event()->IsJSObject() ||
- after_debug_event()->IsUndefined(isolate));
+ CHECK(debug_id()->IsNumber() || debug_id()->IsUndefined(isolate));
+ CHECK(debug_name()->IsString() || debug_name()->IsUndefined(isolate));
CHECK(context()->IsContext());
}
« no previous file with comments | « src/objects.h ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698