Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Unified Diff: src/objects.h

Issue 2415023002: [promises] Move async debug event creation to c++ (Closed)
Patch Set: use consts Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index e9f7c14232223b237179b59596a9c48482d4ad16..b7cac6df3664f169bae057448174220018b7d22a 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -6689,17 +6689,16 @@ class PromiseResolveThenableJobInfo : public Struct {
DECL_ACCESSORS(then, JSReceiver)
DECL_ACCESSORS(resolve, JSFunction)
DECL_ACCESSORS(reject, JSFunction)
- DECL_ACCESSORS(before_debug_event, Object)
- DECL_ACCESSORS(after_debug_event, Object)
+ DECL_ACCESSORS(id, Object)
+ DECL_ACCESSORS(name, Object)
adamk 2016/10/13 15:59:10 In this context, "id" and "name" are too generic.
gsathya 2016/10/13 21:27:30 Agreed about id. Name is either Promise.resolve/re
static const int kThenableOffset = Struct::kHeaderSize;
static const int kThenOffset = kThenableOffset + kPointerSize;
static const int kResolveOffset = kThenOffset + kPointerSize;
static const int kRejectOffset = kResolveOffset + kPointerSize;
- static const int kBeforeDebugEventOffset = kRejectOffset + kPointerSize;
- static const int kAfterDebugEventOffset =
- kBeforeDebugEventOffset + kPointerSize;
- static const int kSize = kAfterDebugEventOffset + kPointerSize;
+ static const int kIdOffset = kRejectOffset + kPointerSize;
+ static const int kNameOffset = kIdOffset + kPointerSize;
+ static const int kSize = kNameOffset + kPointerSize;
DECLARE_CAST(PromiseResolveThenableJobInfo)
DECLARE_PRINTER(PromiseResolveThenableJobInfo)
@@ -6715,17 +6714,16 @@ class PromiseReactionJobInfo : public Struct {
DECL_ACCESSORS(value, Object)
DECL_ACCESSORS(tasks, Object)
DECL_ACCESSORS(deferred, Object)
- DECL_ACCESSORS(before_debug_event, Object)
- DECL_ACCESSORS(after_debug_event, Object)
+ DECL_ACCESSORS(id, Object)
+ DECL_ACCESSORS(name, Object)
DECL_ACCESSORS(context, Context)
static const int kValueOffset = Struct::kHeaderSize;
static const int kTasksOffset = kValueOffset + kPointerSize;
static const int kDeferredOffset = kTasksOffset + kPointerSize;
- static const int kBeforeDebugEventOffset = kDeferredOffset + kPointerSize;
- static const int kAfterDebugEventOffset =
- kBeforeDebugEventOffset + kPointerSize;
- static const int kContextOffset = kAfterDebugEventOffset + kPointerSize;
+ static const int kIdOffset = kDeferredOffset + kPointerSize;
+ static const int kNameOffset = kIdOffset + kPointerSize;
+ static const int kContextOffset = kNameOffset + kPointerSize;
static const int kSize = kContextOffset + kPointerSize;
DECLARE_CAST(PromiseReactionJobInfo)

Powered by Google App Engine
This is Rietveld 408576698