[promises] Move async debug event creation to c++

src/objects-debug.cc

Index: src/objects-debug.cc
diff --git a/src/objects-debug.cc b/src/objects-debug.cc
index afde76404e1dc071547081a79840a66782577420..eb36882980573c292f9692b6a7d3166185f30060 100644
--- a/src/objects-debug.cc
+++ b/src/objects-debug.cc
@@ -919,10 +919,8 @@ void PromiseResolveThenableJobInfo::PromiseResolveThenableJobInfoVerify() {
   CHECK(then()->IsJSReceiver());
   CHECK(resolve()->IsJSFunction());
   CHECK(reject()->IsJSFunction());
-  CHECK(before_debug_event()->IsJSObject() ||
-        before_debug_event()->IsUndefined(isolate));
-  CHECK(after_debug_event()->IsJSObject() ||
-        after_debug_event()->IsUndefined(isolate));
+  CHECK(id()->IsSmi() || id()->IsUndefined(isolate) || id()->IsObject());

[adamk, 2016/10/13 15:59:10]

What is the IsObject() case for (and how could that ever fail?)?

Also, I think IsNumber() is what you want instead of IsSmi() (it's hard to
guarantee that a number created in JS is a Smi).

[gsathya, 2016/10/13 21:27:30]

That was just a catch-all, since Smi isn't guaranteed as you mention below. I
didn't know about IsNumber.
Done.

+  CHECK(name()->IsString() || name()->IsUndefined(isolate));
 }
 
 void PromiseReactionJobInfo::PromiseReactionJobInfoVerify() {
@@ -931,10 +929,8 @@ void PromiseReactionJobInfo::PromiseReactionJobInfoVerify() {
   CHECK(value()->IsObject());
   CHECK(tasks()->IsJSArray() || tasks()->IsCallable());
   CHECK(deferred()->IsJSObject() || deferred()->IsUndefined(isolate));
-  CHECK(before_debug_event()->IsJSObject() ||
-        before_debug_event()->IsUndefined(isolate));
-  CHECK(after_debug_event()->IsJSObject() ||
-        after_debug_event()->IsUndefined(isolate));
+  CHECK(id()->IsSmi() || id()->IsUndefined(isolate) || id()->IsObject());
+  CHECK(name()->IsString() || name()->IsUndefined(isolate));
   CHECK(context()->IsContext());
 }