Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: src/factory.cc

Issue 2415023002: [promises] Move async debug event creation to c++ (Closed)
Patch Set: use consts Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/factory.cc
diff --git a/src/factory.cc b/src/factory.cc
index 1449d0a98a9c0bd572c27ecee03428856a4377da..e3cb3121101f23d063b132c9c48427ff3eb1272c 100644
--- a/src/factory.cc
+++ b/src/factory.cc
@@ -925,8 +925,8 @@ Handle<Struct> Factory::NewStruct(InstanceType type) {
Handle<PromiseResolveThenableJobInfo> Factory::NewPromiseResolveThenableJobInfo(
Handle<JSReceiver> thenable, Handle<JSReceiver> then,
- Handle<JSFunction> resolve, Handle<JSFunction> reject,
- Handle<Object> before_debug_event, Handle<Object> after_debug_event) {
+ Handle<JSFunction> resolve, Handle<JSFunction> reject, Handle<Object> id,
+ Handle<Object> name) {
Handle<PromiseResolveThenableJobInfo> result =
Handle<PromiseResolveThenableJobInfo>::cast(
NewStruct(PROMISE_RESOLVE_THENABLE_JOB_INFO_TYPE));
@@ -934,22 +934,21 @@ Handle<PromiseResolveThenableJobInfo> Factory::NewPromiseResolveThenableJobInfo(
result->set_then(*then);
result->set_resolve(*resolve);
result->set_reject(*reject);
- result->set_before_debug_event(*before_debug_event);
- result->set_after_debug_event(*after_debug_event);
+ result->set_id(*id);
+ result->set_name(*name);
return result;
}
Handle<PromiseReactionJobInfo> Factory::NewPromiseReactionJobInfo(
Handle<Object> value, Handle<Object> tasks, Handle<Object> deferred,
- Handle<Object> before_debug_event, Handle<Object> after_debug_event,
- Handle<Context> context) {
+ Handle<Object> id, Handle<Object> name, Handle<Context> context) {
Handle<PromiseReactionJobInfo> result = Handle<PromiseReactionJobInfo>::cast(
NewStruct(PROMISE_REACTION_JOB_INFO_TYPE));
result->set_value(*value);
result->set_tasks(*tasks);
result->set_deferred(*deferred);
- result->set_before_debug_event(*before_debug_event);
- result->set_after_debug_event(*after_debug_event);
+ result->set_id(*id);
+ result->set_name(*name);
result->set_context(*context);
return result;
}

Powered by Google App Engine
This is Rietveld 408576698