Chromium Code Reviews| Index: src/debug/debug.h |
| diff --git a/src/debug/debug.h b/src/debug/debug.h |
| index 33e4f15c5c13bb22fe6043830637281a6c29bc50..61c41bbfcd5398e70f6675f1d7fe02feee5bdfb0 100644 |
| --- a/src/debug/debug.h |
| +++ b/src/debug/debug.h |
| @@ -417,7 +417,8 @@ class Debug { |
| void OnCompileError(Handle<Script> script); |
| void OnBeforeCompile(Handle<Script> script); |
| void OnAfterCompile(Handle<Script> script); |
| - void OnAsyncTaskEvent(Handle<JSObject> data); |
| + void OnAsyncTaskEvent(Handle<Object> type, Handle<Object> id, |
|
adamk
2016/10/13 15:59:10
This should be able to be more strictly typed: typ
gsathya
2016/10/13 21:27:30
Done.
|
| + Handle<Object> name); |
| // API facing. |
| void SetEventListener(Handle<Object> callback, Handle<Object> data); |
| @@ -588,8 +589,9 @@ class Debug { |
| Handle<Object> promise); |
| MUST_USE_RESULT MaybeHandle<Object> MakeCompileEvent( |
| Handle<Script> script, v8::DebugEvent type); |
| - MUST_USE_RESULT MaybeHandle<Object> MakeAsyncTaskEvent( |
| - Handle<JSObject> task_event); |
| + MUST_USE_RESULT MaybeHandle<Object> MakeAsyncTaskEvent(Handle<Object> type, |
|
adamk
2016/10/13 15:59:10
Same type comment here.
gsathya
2016/10/13 21:27:30
Done.
|
| + Handle<Object> id, |
| + Handle<Object> name); |
| // Mirror cache handling. |
| void ClearMirrorCache(); |