[promises] Move async debug event creation to c++

src/objects-debug.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/objects.h"
 
 #include "src/bootstrapper.h"
 #include "src/disasm.h"
 #include "src/disassembler.h"
 #include "src/field-type.h"
@@ skipping 901 matching lines @@
   value()->ObjectVerify();
 }
 
 void PromiseResolveThenableJobInfo::PromiseResolveThenableJobInfoVerify() {
   Isolate* isolate = GetIsolate();
   CHECK(IsPromiseResolveThenableJobInfo());
   CHECK(thenable()->IsJSReceiver());
   CHECK(then()->IsJSReceiver());
   CHECK(resolve()->IsJSFunction());
   CHECK(reject()->IsJSFunction());
-  CHECK(before_debug_event()->IsJSObject() ||
-        before_debug_event()->IsUndefined(isolate));
-  CHECK(after_debug_event()->IsJSObject() ||
-        after_debug_event()->IsUndefined(isolate));
+  CHECK(id()->IsSmi() || id()->IsUndefined(isolate) || id()->IsObject());

[adamk, 2016/10/13 15:59:10]

What is the IsObject() case for (and how could that ever fail?)?

Also, I think IsNumber() is what you want instead of IsSmi() (it's hard to
guarantee that a number created in JS is a Smi).

[gsathya, 2016/10/13 21:27:30]

That was just a catch-all, since Smi isn't guaranteed as you mention below. I
didn't know about IsNumber.
Done.

+  CHECK(name()->IsString() || name()->IsUndefined(isolate));
 }
 
 void PromiseReactionJobInfo::PromiseReactionJobInfoVerify() {
   Isolate* isolate = GetIsolate();
   CHECK(IsPromiseReactionJobInfo());
   CHECK(value()->IsObject());
   CHECK(tasks()->IsJSArray() || tasks()->IsCallable());
   CHECK(deferred()->IsJSObject() || deferred()->IsUndefined(isolate));
-  CHECK(before_debug_event()->IsJSObject() ||
-        before_debug_event()->IsUndefined(isolate));
-  CHECK(after_debug_event()->IsJSObject() ||
-        after_debug_event()->IsUndefined(isolate));
+  CHECK(id()->IsSmi() || id()->IsUndefined(isolate) || id()->IsObject());
+  CHECK(name()->IsString() || name()->IsUndefined(isolate));
   CHECK(context()->IsContext());
 }
 
 void JSModuleNamespace::JSModuleNamespaceVerify() {
   CHECK(IsJSModuleNamespace());
   module()->ObjectVerify();
 }
 
 void Module::ModuleVerify() {
   Isolate* isolate = GetIsolate();
@@ skipping 440 matching lines @@
 
   // Both are done at the same time.
   CHECK_EQ(new_it.done(), old_it.done());
 }
 
 
 #endif  // DEBUG
 
 }  // namespace internal
 }  // namespace v8