Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 2415013002: Don't throttle disposed FrameViews (Closed)

Created:
4 years, 2 months ago by Sami
Modified:
4 years, 1 month ago
Reviewers:
dcheng
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't throttle disposed FrameViews After a FrameView has been disposed, don't allow throttling the rendering pipeline for it because we can no longer reliably determine if the FrameView is visible. BUG=637373

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 3 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
Sami
So this fixes the iframe not getting painted, but I feel like I'm still missing ...
4 years, 2 months ago (2016-10-13 03:27:57 UTC) #5
dcheng
Hmm, yeah something seems really broken. Let me poke at this bug tomorrow when I'm ...
4 years, 2 months ago (2016-10-13 04:41:25 UTC) #6
Sami
4 years, 2 months ago (2016-10-13 04:45:02 UTC) #7
On 2016/10/13 04:41:25, dcheng wrote:
> Hmm, yeah something seems really broken. Let me poke at this bug tomorrow when
> I'm in the office. Once disposed, I don't think a FrameView should really be
> involving itself in layout (as its LocalFrame should be in the process of
being
> removed from the DOM).

Thanks, I'd appreciate a second pair of eyes on this!

Powered by Google App Engine
This is Rietveld 408576698