Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: pkg/barback/lib/src/transform_node.dart

Issue 241493002: Don't warn if a transformer declares outputs that it doesn't emit. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/barback/CHANGELOG.md ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/barback/lib/src/transform_node.dart
diff --git a/pkg/barback/lib/src/transform_node.dart b/pkg/barback/lib/src/transform_node.dart
index 5eb0e6b5c36c687fd90be766fcc8ee535756f95f..65dce6ec376a2b3e71278c89b8da3e25821b2a27 100644
--- a/pkg/barback/lib/src/transform_node.dart
+++ b/pkg/barback/lib/src/transform_node.dart
@@ -411,16 +411,6 @@ class TransformNode {
phase.cascade.reportError(new InvalidOutputException(info, id));
}
- if (_declaredOutputs != null) {
- var missingOutputs = _declaredOutputs.difference(
- newOutputs.map((asset) => asset.id).toSet());
- if (missingOutputs.isNotEmpty) {
- _warn("This transformer didn't emit declared "
- "${pluralize('output asset', missingOutputs.length)} "
- "${toSentence(missingOutputs)}.");
- }
- }
-
// Remove outputs that used to exist but don't anymore.
for (var id in _outputControllers.keys.toList()) {
if (newOutputs.containsId(id)) continue;
« no previous file with comments | « pkg/barback/CHANGELOG.md ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698