Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1180)

Unified Diff: pkg/polymer/lib/src/build/runner.dart

Issue 24149003: Port of github.com/polymer/polymer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/polymer/lib/src/build/linter.dart ('k') | pkg/polymer/lib/src/build/utils.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/polymer/lib/src/build/runner.dart
diff --git a/pkg/polymer/lib/src/build/runner.dart b/pkg/polymer/lib/src/build/runner.dart
index d940c184b733257db4c0fb892cb0280dbf38e673..3596e923b440365a16655b2b2b44b4803fc339fc 100644
--- a/pkg/polymer/lib/src/build/runner.dart
+++ b/pkg/polymer/lib/src/build/runner.dart
@@ -105,7 +105,7 @@ Map<String, String> _readPackageDirsFromPub(String currentPackage) {
final Set<String> _polymerPackageDependencies = [
'analyzer_experimental', 'args', 'barback', 'browser', 'csslib',
'custom_element', 'fancy_syntax', 'html5lib', 'html_import', 'js',
- 'logging', 'mdv', 'meta', 'mutation_observer', 'observe', 'path', 'polymer',
+ 'logging', 'mdv', 'meta', 'mutation_observer', 'observe', 'path'
'polymer_expressions', 'serialization', 'shadow_dom', 'source_maps',
'stack_trace', 'unittest', 'unmodifiable_collection', 'yaml'].toSet();
@@ -149,7 +149,9 @@ void _initBarback(Barback barback, BarbackOptions options) {
}
for (var package in options.packageDirs.keys) {
- // There is nothing to do in the 'polymer' package and its dependencies.
+ // There is nothing to do in the polymer package dependencies.
+ // However: in Polymer package *itself*, we need to replace ObservableMixin
+ // with ChangeNotifierMixin.
if (!options.transformPolymerDependencies &&
_polymerPackageDependencies.contains(package)) continue;
barback.updateTransformers(package, options.phases);
« no previous file with comments | « pkg/polymer/lib/src/build/linter.dart ('k') | pkg/polymer/lib/src/build/utils.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698