Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2414883005: TEMP DO NOT LAND (Closed)

Created:
4 years, 2 months ago by xunjieli
Modified:
4 years, 1 month ago
Reviewers:
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

TEMP DO NOT LAND patch from issue 2397563002 at patchset 1 (http://crrev.com/2397563002#ps1) BUG=

Patch Set 1 #

Patch Set 2 : temp #

Total comments: 2

Patch Set 3 : temp #

Patch Set 4 : temp #

Patch Set 5 : temp #

Patch Set 6 : tmp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+308 lines, -4 lines) Patch
M chrome/browser/io_thread.cc View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 2 3 4 3 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_network_session.h View 1 2 3 4 2 chunks +6 lines, -0 lines 0 comments Download
M net/http/http_network_session.cc View 1 2 3 4 2 chunks +21 lines, -0 lines 0 comments Download
M net/socket/client_socket_pool.h View 2 chunks +6 lines, -0 lines 0 comments Download
M net/socket/client_socket_pool.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M net/socket/client_socket_pool_base.h View 2 chunks +8 lines, -0 lines 0 comments Download
M net/socket/client_socket_pool_base.cc View 1 2 3 4 5 2 chunks +23 lines, -0 lines 0 comments Download
M net/socket/client_socket_pool_manager.h View 2 chunks +5 lines, -0 lines 0 comments Download
M net/socket/client_socket_pool_manager_impl.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
M net/socket/client_socket_pool_manager_impl.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M net/socket/socket_bio_adapter.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M net/socket/socket_bio_adapter.cc View 1 2 3 4 5 2 chunks +14 lines, -0 lines 0 comments Download
M net/socket/ssl_client_socket_impl.h View 1 2 3 4 3 chunks +10 lines, -0 lines 0 comments Download
M net/socket/ssl_client_socket_impl.cc View 1 2 3 4 5 5 chunks +52 lines, -1 line 0 comments Download
M net/socket/ssl_client_socket_pool.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M net/socket/stream_socket.h View 1 2 3 2 chunks +9 lines, -0 lines 0 comments Download
M net/socket/stream_socket.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M net/ssl/ssl_client_session_cache.h View 1 2 3 4 2 chunks +5 lines, -0 lines 0 comments Download
M net/ssl/ssl_client_session_cache.cc View 1 2 3 4 5 3 chunks +43 lines, -0 lines 0 comments Download
M net/url_request/url_request.h View 1 2 3 4 2 chunks +6 lines, -0 lines 0 comments Download
M net/url_request/url_request.cc View 1 2 3 4 2 chunks +16 lines, -0 lines 0 comments Download
M net/url_request/url_request_context.h View 1 5 chunks +16 lines, -2 lines 0 comments Download
M net/url_request/url_request_context.cc View 1 2 3 4 3 chunks +32 lines, -1 line 0 comments Download

Messages

Total messages: 4 (3 generated)
ssid
4 years, 2 months ago (2016-10-14 18:52:25 UTC) #2
few thoughts. Let me know if it helps.

https://codereview.chromium.org/2414883005/diff/20001/net/http/http_network_s...
File net/http/http_network_session.cc (right):

https://codereview.chromium.org/2414883005/diff/20001/net/http/http_network_s...
net/http/http_network_session.cc:383: base::trace_event::MemoryAllocatorDump*
dump) const {
Maybe pass ProcessMemoryDump* here, with a root name as
"net/url_request_context_X/media_X"

You can add extra id from here and create allocator dump:

name = root_name + "/http_request_X"
pmd->createDump(name);

https://codereview.chromium.org/2414883005/diff/20001/net/http/http_network_s...
net/http/http_network_session.cc:395:
normal_socket_pool_manager_->PopulateAllocatorDump(http_network_session_dump);
The code could be:

name = root_name + "/http_request_X"
dump = pmd->createDump(name);
dump->AddScalar(size);

target_name = "net/url_request_context/all_http_sessions/session_X"
target_dump = pmd->GetAllocatorDump(target_name);
if (!target_dump) {
  target_dmup = pmd->GetAllocatorDump(target_name)
  target_dump->AddScalar(size);
}
// This will take the effective_size away from the 
// "all_http_sesisons" pool and give it to the media/ dump.
pmd->AddOwnershipEdge(dump, target_dump);

Powered by Google App Engine
This is Rietveld 408576698