Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2414783002: Add GN files that need exec_script to list for win64 clang-cl (Closed)

Created:
4 years, 2 months ago by fbarchard1
Modified:
4 years, 2 months ago
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Add GN files that need exec_script to list for win64 clang-cl TBR=kjellander@chromium.org BUG=libyuv:649 TEST=call gn gen out\Release "--args=is_debug=false is_clang=true" Committed: https://chromium.googlesource.com/libyuv/libyuv/+/a7166c337514e37646de97f4aad81254358cc92c

Patch Set 1 #

Patch Set 2 : remove webrtc changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M .gn View 1 3 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
fbarchard1
this allows GN to generate ninja files for win64 clang-cl Was call gn gen out\Release ...
4 years, 2 months ago (2016-10-12 19:38:05 UTC) #2
fbarchard1
Committed patchset #2 (id:20001) manually as a7166c337514e37646de97f4aad81254358cc92c (presubmit successful).
4 years, 2 months ago (2016-10-12 19:46:28 UTC) #5
kjellander_chromium
4 years, 2 months ago (2016-10-12 20:19:09 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698