Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2414763002: Cast for clang-cl 64 bit build warnings in unittests (Closed)

Created:
4 years, 2 months ago by fbarchard1
Modified:
4 years, 2 months ago
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : additional casts for signed comparisons #

Patch Set 3 : bump version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -31 lines) Patch
M README.chromium View 1 2 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/version.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M unit_test/compare_test.cc View 1 4 chunks +10 lines, -10 lines 0 comments Download
M unit_test/convert_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M unit_test/cpu_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M unit_test/video_common_test.cc View 1 chunk +17 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
kjellander_chromium
lgtm
4 years, 2 months ago (2016-10-12 20:03:06 UTC) #2
fbarchard1
4 years, 2 months ago (2016-10-12 20:10:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
198bce39590b60486d9d5f1f10a6a0e03d8c6d8b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698