Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2414673002: Disable two cocoa FramedBrowserWindowTest tests. (Closed)

Created:
4 years, 2 months ago by msramek
Modified:
4 years, 2 months ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable two cocoa FramedBrowserWindowTest tests. The following tests: FramedBrowserWindowTest.WindowWidgetLocation FramedBrowserWindowTest.DoesHideTitle were broken by https://codereview.chromium.org/2416513002/. TBR=eugenebut@chromium.org,tapted@chromium.org BUG=655112 Committed: https://crrev.com/cd7d6f600a2b4d2095fe7bd6d94af29289075c8b Cr-Commit-Position: refs/heads/master@{#424725}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/framed_browser_window_unittest.mm View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
msramek
This is a followup to https://codereview.chromium.org/2412653004/ - disabling two more tests mentioned in crbug.com/655112. Adding ...
4 years, 2 months ago (2016-10-12 13:22:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2414673002/1
4 years, 2 months ago (2016-10-12 13:22:40 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 13:28:25 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 13:31:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd7d6f600a2b4d2095fe7bd6d94af29289075c8b
Cr-Commit-Position: refs/heads/master@{#424725}

Powered by Google App Engine
This is Rietveld 408576698