Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: BUILD.gn

Issue 2414633002: Disable warning for signed/unsigned mismatch in MSVC (Closed)
Patch Set: Disable sign compare warning for tests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index ef0003273d22d2e6af1a7ca4f925bff40455d049..2dfb94c8a5b80f78acf0cd5ea4f4f671fd35b7e8 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -49,9 +49,17 @@ config("libsrtp_config") {
]
}
+config("libsrtp_warnings") {
+ cflags = []
+ if (is_win) {
+ cflags += [ "/wd4018" ] # Signed/unsigned mismatch in comparison
+ }
+}
+
static_library("libsrtp") {
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
+ configs += [ ":libsrtp_warnings" ]
public_configs = [ ":libsrtp_config" ]
sources = [
# includes
@@ -108,6 +116,15 @@ static_library("libsrtp") {
config("srtp_test_config") {
include_dirs = [ "test" ]
+
+ configs = [ ":libsrtp_warnings" ]
+
+ cflags = []
+ if (is_win && is_clang) {
kjellander_chromium 2016/10/12 22:59:48 Does this work even if it's not in a config? Becau
mattdr-at-chromium 2016/10/12 23:01:26 This is in a config, now, so it should come in aft
kjellander_chromium 2016/10/12 23:56:52 Oh, I dunno why I didn't see it was in a config al
+ # TODO(mattdr): Bring in https://github.com/cisco/libsrtp/pull/213
+ # and remove this.
+ cflags += [ "-Wno-format" ]
+ }
}
template("srtp_test") {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698