Disable warning for signed/unsigned mismatch in MSVC

Disable warning for signed/unsigned mismatch in MSVC

BUG=
R=kjellander@chromium.org

Committed: https://chromium.googlesource.com/chromium/deps/libsrtp/+/eccff9b521866c448813ad91ed2c00624d46bca2

[mattdr-at-chromium, 2016-10-12 06:03:26]

mattdr@chromium.org changed reviewers:
+ kjellander@chromium.org

[mattdr-at-chromium, 2016-10-12 06:03:27]

Ever closer. :)

This fixes the warning we saw on the Windows trybots in
https://codereview.chromium.org/2398073002/.

[kjellander_chromium, 2016-10-12 20:22:30]

You need to do a similar fix for Win Clang as well, see this for an example:
https://cs.chromium.org/chromium/src/third_party/webrtc/modules/audio_coding/...

You probably need to put it in a config as well, since otherwise the -Wno-format
entry won't end up after the original one on the command line. There are plenty
of examples of that in WebRTC, which is kind of annoying.

[kjellander_chromium, 2016-10-12 20:22:51]

On 2016/10/12 20:22:30, kjellander_chromium wrote:
> You need to do a similar fix for Win Clang as well, see this for an example:
>
https://cs.chromium.org/chromium/src/third_party/webrtc/modules/audio_coding/...
> 
> You probably need to put it in a config as well, since otherwise the
-Wno-format
> entry won't end up after the original one on the command line. There are
plenty
> of examples of that in WebRTC, which is kind of annoying.

Failure for Win Clang:
https://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds...

[mattdr-at-chromium, 2016-10-12 22:53:30]

On 2016/10/12 20:22:51, kjellander_chromium wrote:
> On 2016/10/12 20:22:30, kjellander_chromium wrote:
> > You need to do a similar fix for Win Clang as well, see this for an example:
> >
>
https://cs.chromium.org/chromium/src/third_party/webrtc/modules/audio_coding/...
> > 
> > You probably need to put it in a config as well, since otherwise the
> -Wno-format
> > entry won't end up after the original one on the command line. There are
> plenty
> > of examples of that in WebRTC, which is kind of annoying.
> 
> Failure for Win Clang:
>
https://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds...

This should do it.
- Pass -Wno-format in a config for Windows+Clang. Only applies in tests. Only a
problem on Windows because be32_to_cpu = htonl returns 'unsigned int' everywhere
else.
- Pass /wd4018 in a config for Windows. This is MSVC-specific and properly
ignored by Clang. C4018 is a /W3 warning on MSVC, which means it's enabled for
no_chromium_code. The GCC/Clang equivalent, -Wsign-compare, is included in
-Wextra and only enabled for chromium_code in our build.

[kjellander_chromium, 2016-10-12 22:59:48]

lgtm

https://codereview.chromium.org/2414633002/diff/60001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2414633002/diff/60001/BUILD.gn#newcode123
BUILD.gn:123: if (is_win && is_clang) {
Does this work even if it's not in a config? Because in my experience that was
not the case many times when I was battling with Win Clang errors in WebRTC.
I was just hoping you're certain or has tested this.

[mattdr-at-chromium, 2016-10-12 23:01:27]

https://codereview.chromium.org/2414633002/diff/60001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2414633002/diff/60001/BUILD.gn#newcode123
BUILD.gn:123: if (is_win && is_clang) {
On 2016/10/12 22:59:48, kjellander_chromium wrote:
> Does this work even if it's not in a config? Because in my experience that was
> not the case many times when I was battling with Win Clang errors in WebRTC.
> I was just hoping you're certain or has tested this.

This is in a config, now, so it should come in after the cflags in
no_chromium_code.

[mattdr-at-chromium, 2016-10-12 23:05:17]

On 2016/10/12 23:01:27, mattdr-at-chromium wrote:
> https://codereview.chromium.org/2414633002/diff/60001/BUILD.gn
> File BUILD.gn (right):
> 
> https://codereview.chromium.org/2414633002/diff/60001/BUILD.gn#newcode123
> BUILD.gn:123: if (is_win && is_clang) {
> On 2016/10/12 22:59:48, kjellander_chromium wrote:
> > Does this work even if it's not in a config? Because in my experience that
was
> > not the case many times when I was battling with Win Clang errors in WebRTC.
> > I was just hoping you're certain or has tested this.
> 
> This is in a config, now, so it should come in after the cflags in
> no_chromium_code.

Of course, I must impose on you again to land this CL. Thanks, and sorry for the
trouble.

I think it might work this time. :)

[kjellander_chromium, 2016-10-12 23:56:52]

I'll land this for you.

https://codereview.chromium.org/2414633002/diff/60001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2414633002/diff/60001/BUILD.gn#newcode123
BUILD.gn:123: if (is_win && is_clang) {
On 2016/10/12 23:01:26, mattdr-at-chromium wrote:
> On 2016/10/12 22:59:48, kjellander_chromium wrote:
> > Does this work even if it's not in a config? Because in my experience that
was
> > not the case many times when I was battling with Win Clang errors in WebRTC.
> > I was just hoping you're certain or has tested this.
> 
> This is in a config, now, so it should come in after the cflags in
> no_chromium_code.

Oh, I dunno why I didn't see it was in a config already, sorry ;)

[kjellander_chromium, 2016-10-12 23:57:32]

Description was changed from

==========
Disable warning for signed/unsigned mismatch in MSVC

BUG=
==========

to

==========
Disable warning for signed/unsigned mismatch in MSVC

BUG=
R=kjellander@chromium.org

Committed:
https://chromium.googlesource.com/chromium/deps/libsrtp/+/eccff9b521866c44881...
==========

[kjellander_chromium, 2016-10-12 23:57:33]

Committed patchset #5 (id:80001) manually as
eccff9b521866c448813ad91ed2c00624d46bca2 (presubmit successful).