ash: Use legacy size for legacy logout button.

ash: Use legacy size for legacy logout button.

BUG=654803
Committed: https://crrev.com/6f35d15d1ad0fa7a5f87f5ad47d4fc33aa695d66
Cr-Commit-Position: refs/heads/master@{#424750}

[xiyuan, 2016-10-11 22:10:50]

xiyuan@chromium.org changed reviewers:
+ sadrul@chromium.org, tdanderson@chromium.org

[xiyuan, 2016-10-11 22:10:50]

Fix the logout button size regression in
https://codereview.chromium.org/2218323002.

Screenshot of the CL is at the bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=654803#c5

[xiyuan, 2016-10-11 22:11:07]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 22:11:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 22:46:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 22:46:23]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-10-12 00:43:42]

I have a nit. I will defer to Terry for approval

https://codereview.chromium.org/2414533002/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/session/logout_button_tray.cc (right):

https://codereview.chromium.org/2414533002/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/session/logout_button_tray.cc:185: const int
kButtonMinSize = MaterialDesignController::IsShelfMaterial()
I think this would just be 'const int button_size = ...';

[tdanderson, 2016-10-12 15:02:08]

Thanks for filing and fixing this! LGTM

[xiyuan, 2016-10-12 15:28:12]

https://codereview.chromium.org/2414533002/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/session/logout_button_tray.cc (right):

https://codereview.chromium.org/2414533002/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/session/logout_button_tray.cc:185: const int
kButtonMinSize = MaterialDesignController::IsShelfMaterial()
On 2016/10/12 00:43:42, sadrul wrote:
> I think this would just be 'const int button_size = ...';

Done.

[xiyuan, 2016-10-12 15:28:18]

The CQ bit was checked by xiyuan@chromium.org

[xiyuan, 2016-10-12 15:28:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org
Link to the patchset: https://codereview.chromium.org/2414533002/#ps20001
(title: "fix nit: kButtonMinSize -> button_size")

[commit-bot: I haz the power, 2016-10-12 15:28:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 15:53:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-12 15:55:32]

Description was changed from

==========
ash: Use legacy size for legacy logout button.

BUG=654803
==========

to

==========
ash: Use legacy size for legacy logout button.

BUG=654803

Committed: https://crrev.com/6f35d15d1ad0fa7a5f87f5ad47d4fc33aa695d66
Cr-Commit-Position: refs/heads/master@{#424750}
==========

[commit-bot: I haz the power, 2016-10-12 15:55:33]

Patchset 2 (id:??) landed as
https://crrev.com/6f35d15d1ad0fa7a5f87f5ad47d4fc33aa695d66
Cr-Commit-Position: refs/heads/master@{#424750}

[Evan Stade, 2016-10-20 16:43:15]

estade@chromium.org changed reviewers:
+ estade@chromium.org

[Evan Stade, 2016-10-20 16:43:16]

thanks!

https://codereview.chromium.org/2414533002/diff/20001/ash/common/system/chrom...
File ash/common/system/chromeos/session/logout_button_tray.cc (right):

https://codereview.chromium.org/2414533002/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/session/logout_button_tray.cc:187: :
GetTrayConstant(TRAY_ITEM_HEIGHT_LEGACY);
minor quibble: technically I don't believe this ternary is necessary