Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1713)

Unified Diff: appengine/findit/crash/test/results_test.py

Issue 2414523002: [Findit] Reorganizing findit_for_*.py (Closed)
Patch Set: Finally fixed the mock tests! Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/crash/test/results_test.py
diff --git a/appengine/findit/crash/test/results_test.py b/appengine/findit/crash/test/results_test.py
index 4e8a20b399e4a37432490feb92c7d15d1577b5b9..0cf7ee6183808a300d7f9ef564b550b69329828f 100644
--- a/appengine/findit/crash/test/results_test.py
+++ b/appengine/findit/crash/test/results_test.py
@@ -6,6 +6,7 @@ from common.blame import Region
from common.blame import Blame
from common.change_log import ChangeLog
from crash.stacktrace import StackFrame
+from crash.results import AnalysisInfo
from crash.results import Result
from crash.results import MatchResult
from crash.results import MatchResults
@@ -121,7 +122,7 @@ class ResultsTest(CrashTestSuite):
stack_infos = [(StackFrame(0, 'src/', 'func', 'a.cc', 'src/a.cc', [7]), 0)]
result.Update('a.cc', stack_infos, DUMMY_BLAME)
- self.assertEqual(result.file_to_analysis_info['a.cc']['min_distance'], 0)
+ self.assertEqual(result.file_to_analysis_info['a.cc'].min_distance, 0)
# Touched lines are before crashed lines.
result = MatchResult(DUMMY_CHANGELOG1, 'src/', confidence=1)
@@ -129,7 +130,7 @@ class ResultsTest(CrashTestSuite):
stack_infos = [(StackFrame(0, 'src/', 'func', 'a.cc', 'src/a.cc', [3]), 0)]
result.Update('a.cc', stack_infos, DUMMY_BLAME)
- self.assertEqual(result.file_to_analysis_info['a.cc']['min_distance'], 3)
+ self.assertEqual(result.file_to_analysis_info['a.cc'].min_distance, 3)
# Touched lines are after crashed lines.
result = MatchResult(DUMMY_CHANGELOG1, 'src/', confidence=1)
@@ -137,7 +138,7 @@ class ResultsTest(CrashTestSuite):
stack_infos = [(StackFrame(0, 'src/', 'func', 'a.cc', 'src/a.cc', [10]), 0)]
result.Update('a.cc', stack_infos, DUMMY_BLAME)
- self.assertEqual(result.file_to_analysis_info['a.cc']['min_distance'], 2)
+ self.assertEqual(result.file_to_analysis_info['a.cc'].min_distance, 2)
def testMatchResultUpdateWithEmptyBlame(self):
result = MatchResult(DUMMY_CHANGELOG1, 'src/', confidence=1)
@@ -155,8 +156,8 @@ class ResultsTest(CrashTestSuite):
result.Update('a.cc', stack_infos, DUMMY_BLAME)
self.assertEqual(result.file_to_stack_infos['a.cc'], stack_infos)
- self.assertEqual(result.file_to_analysis_info, {'a.cc': {
- 'min_distance': 0, 'min_distance_frame': frame1}})
+ self.assertEqual(result.file_to_analysis_info,
+ {'a.cc': AnalysisInfo(min_distance = 0, min_distance_frame = frame1)})
def testMatchResultsGenerateMatchResults(self):
match_results = MatchResults(ignore_cls=set(['2']))
@@ -178,8 +179,8 @@ class ResultsTest(CrashTestSuite):
'b.cc': stack_infos2,
}
expected_match_result.file_to_analysis_info = {
- 'a.cc': {'min_distance': 0, 'min_distance_frame': frame1},
- 'b.cc': {'min_distance': 3, 'min_distance_frame': frame2},
+ 'a.cc': AnalysisInfo(min_distance = 0, min_distance_frame = frame1),
+ 'b.cc': AnalysisInfo(min_distance = 3, min_distance_frame = frame2),
}
expected_match_results = MatchResults(ignore_cls=set(['2']))
« no previous file with comments | « appengine/findit/crash/test/project_classifier_test.py ('k') | appengine/findit/crash/test/stacktrace_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698