Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: appengine/findit/crash/component.py

Issue 2414523002: [Findit] Reorganizing findit_for_*.py (Closed)
Patch Set: Finally fixed the mock tests! Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/crash/classifier.py ('k') | appengine/findit/crash/component_classifier.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/crash/component.py
diff --git a/appengine/findit/crash/component.py b/appengine/findit/crash/component.py
index 37f1f2ce91d258e8b6ead21821fd8fd181860ed6..1872b69dfb52ef8a13cb4b0f7e45dfecd443dac3 100644
--- a/appengine/findit/crash/component.py
+++ b/appengine/findit/crash/component.py
@@ -2,12 +2,12 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-import collections
+from collections import namedtuple
import re
-# TODO(wrengr): write the coverage tests the old version was lacking.
-class Component(collections.namedtuple('Component',
+# TODO(http://crbug.com/659346): write the coverage tests.
+class Component(namedtuple('Component',
['component_name', 'path_regex', 'function_regex'])): # pragma: no cover
"""A representation of a "component" in Chromium.
« no previous file with comments | « appengine/findit/crash/classifier.py ('k') | appengine/findit/crash/component_classifier.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698