Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2352)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: appengine/findit/crash/test/findit_for_crash_test.py

Issue 2414523002: [Findit] Reorganizing findit_for_*.py (Closed)
Patch Set: Finally fixed the mock tests! Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/crash/test/findit_for_client_test.py ('k') | appengine/findit/crash/test/findit_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/crash/test/findit_for_crash_test.py
diff --git a/appengine/findit/crash/test/findit_for_crash_test.py b/appengine/findit/crash/test/findit_for_crash_test.py
deleted file mode 100644
index a6ad46921c4d1fac165f7abcef5f18135051a109..0000000000000000000000000000000000000000
--- a/appengine/findit/crash/test/findit_for_crash_test.py
+++ /dev/null
@@ -1,422 +0,0 @@
-# Copyright 2016 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-from collections import defaultdict
-
-from common import git_repository
-from common.blame import Region
-from common.blame import Blame
-from common.change_log import ChangeLog
-from common.dependency import Dependency
-from common.dependency import DependencyRoll
-from common.http_client_appengine import HttpClientAppengine
-from crash import findit_for_crash
-from crash.stacktrace import StackFrame
-from crash.stacktrace import CallStack
-from crash.stacktrace import Stacktrace
-from crash.results import MatchResult
-from crash.test.crash_test_suite import CrashTestSuite
-
-
-DUMMY_CHANGELOG1 = ChangeLog.FromDict({
- 'author_name': 'r@chromium.org',
- 'message': 'dummy',
- 'committer_email': 'r@chromium.org',
- 'commit_position': 175900,
- 'author_email': 'r@chromium.org',
- 'touched_files': [
- {
- 'change_type': 'add',
- 'new_path': 'a.cc',
- 'old_path': None,
- },
- ],
- 'author_time': 'Thu Mar 31 21:24:43 2016',
- 'committer_time': 'Thu Mar 31 21:28:39 2016',
- 'commit_url':
- 'https://repo.test/+/1',
- 'code_review_url': 'https://codereview.chromium.org/3281',
- 'committer_name': 'example@chromium.org',
- 'revision': '1',
- 'reverted_revision': None
-})
-
-DUMMY_CHANGELOG2 = ChangeLog.FromDict({
- 'author_name': 'example@chromium.org',
- 'message': 'dummy',
- 'committer_email': 'example@chromium.org',
- 'commit_position': 175976,
- 'author_email': 'example@chromium.org',
- 'touched_files': [
- {
- 'change_type': 'add',
- 'new_path': 'f0.cc',
- 'old_path': 'b/f0.cc'
- },
- ],
- 'author_time': 'Thu Mar 31 21:24:43 2016',
- 'committer_time': 'Thu Mar 31 21:28:39 2016',
- 'commit_url':
- 'https://repo.test/+/2',
- 'code_review_url': 'https://codereview.chromium.org/3281',
- 'committer_name': 'example@chromium.org',
- 'revision': '2',
- 'reverted_revision': '1'
-})
-
-DUMMY_CHANGELOG3 = ChangeLog.FromDict({
- 'author_name': 'e@chromium.org',
- 'message': 'dummy',
- 'committer_email': 'e@chromium.org',
- 'commit_position': 176000,
- 'author_email': 'e@chromium.org',
- 'touched_files': [
- {
- 'change_type': 'modify',
- 'new_path': 'f.cc',
- 'old_path': 'f.cc'
- },
- {
- 'change_type': 'delete',
- 'new_path': None,
- 'old_path': 'f1.cc'
- },
- ],
- 'author_time': 'Thu Apr 1 21:24:43 2016',
- 'committer_time': 'Thu Apr 1 21:28:39 2016',
- 'commit_url':
- 'https://repo.test/+/3',
- 'code_review_url': 'https://codereview.chromium.org/3281',
- 'committer_name': 'example@chromium.org',
- 'revision': '3',
- 'reverted_revision': None
-})
-
-
-class FinditForCrashTest(CrashTestSuite):
-
- def testGetDepsInCrashStack(self):
- crash_stack = CallStack(0)
- crash_stack.extend([
- StackFrame(0, 'src/', 'func0', 'f0.cc', 'src/f0.cc', [1]),
- StackFrame(1, 'src/', 'func1', 'f1.cc', 'src/f1.cc', [2, 3]),
- StackFrame(1, '', 'func2', 'f2.cc', 'src/f2.cc', [2, 3]),
- ])
- crash_deps = {'src/': Dependency('src/', 'https://chromium_repo', '1'),
- 'src/v8/': Dependency('src/v8/', 'https://v8_repo', '2')}
-
- expected_stack_deps = {'src/': crash_deps['src/']}
-
- self.assertEqual(
- findit_for_crash.GetDepsInCrashStack(crash_stack, crash_deps),
- expected_stack_deps)
-
- def testGetChangeLogsForFilesGroupedByDeps(self):
- regression_deps_rolls = {
- 'src/dep1': DependencyRoll('src/dep1', 'https://url_dep1', '7', '9'),
- 'src/dep2': DependencyRoll('src/dep2', 'repo_url', '3', None),
- 'src/': DependencyRoll('src/', ('https://chromium.googlesource.com/'
- 'chromium/src.git'), '4', '5')
- }
-
- stack_deps = {
- 'src/': Dependency('src/', 'https://url_src', 'rev1', 'DEPS'),
- 'src/new': Dependency('src/new', 'https://new', 'rev2', 'DEPS'),
- }
-
- def _MockGetChangeLogs(*_):
- return [DUMMY_CHANGELOG1, DUMMY_CHANGELOG2, DUMMY_CHANGELOG3]
-
- self.mock(git_repository.GitRepository, 'GetChangeLogs', _MockGetChangeLogs)
-
- dep_file_to_changelogs, ignore_cls = (
- findit_for_crash.GetChangeLogsForFilesGroupedByDeps(
- regression_deps_rolls, stack_deps, git_repository.GitRepository()))
- dep_file_to_changelogs_json = defaultdict(lambda: defaultdict(list))
- for dep, file_to_changelogs in dep_file_to_changelogs.iteritems():
- for file_path, changelogs in file_to_changelogs.iteritems():
- for changelog in changelogs:
- dep_file_to_changelogs_json[dep][file_path].append(changelog.ToDict())
-
- expected_dep_file_to_changelogs_json = {
- 'src/': {
- 'a.cc': [DUMMY_CHANGELOG1.ToDict()],
- 'f.cc': [DUMMY_CHANGELOG3.ToDict()]
- }
- }
- self.assertEqual(dep_file_to_changelogs_json,
- expected_dep_file_to_changelogs_json)
- self.assertEqual(ignore_cls, set(['1']))
-
- def testGetStackInfosForFilesGroupedByDeps(self):
-
- main_stack = CallStack(0)
- main_stack.extend(
- [StackFrame(0, 'src/', 'c(p* &d)', 'a.cc', 'src/a.cc', [177]),
- StackFrame(1, 'src/', 'd(a* c)', 'a.cc', 'src/a.cc', [227, 228, 229]),
- StackFrame(2, 'src/v8/', 'e(int)', 'b.cc', 'src/v8/b.cc', [89, 90])])
-
- low_priority_stack = CallStack(1)
- low_priority_stack.append(
- StackFrame(0, 'src/dummy/', 'c(p* &d)', 'd.cc', 'src/dummy/d.cc', [17]))
-
- stacktrace = Stacktrace()
- stacktrace.extend([main_stack, low_priority_stack])
-
- crashed_deps = {'src/': Dependency('src/', 'https//repo', '2'),
- 'src/v8/': Dependency('src/v8', 'https//repo', '1')}
-
- expected_dep_file_to_stack_infos = {
- 'src/': {
- 'a.cc': [
- (main_stack[0], 0),
- (main_stack[1], 0),
- ],
- },
- 'src/v8/': {
- 'b.cc': [
- (main_stack[2], 0),
- ]
- }
- }
-
- dep_file_to_stack_infos = (
- findit_for_crash.GetStackInfosForFilesGroupedByDeps(
- stacktrace, crashed_deps))
-
- self.assertEqual(len(dep_file_to_stack_infos),
- len(expected_dep_file_to_stack_infos))
-
- for dep, file_to_stack_infos in dep_file_to_stack_infos.iteritems():
- self.assertTrue(dep in expected_dep_file_to_stack_infos)
- expected_file_to_stack_infos = expected_dep_file_to_stack_infos[dep]
-
- for file_path, stack_infos in file_to_stack_infos.iteritems():
- self.assertTrue(file_path in expected_file_to_stack_infos)
- expected_stack_infos = expected_file_to_stack_infos[file_path]
-
- self._VerifyTwoStackInfosEqual(stack_infos, expected_stack_infos)
-
- def testFindMatchResults(self):
- dep_file_to_changelogs = {
- 'src/': {
- 'a.cc': [
- DUMMY_CHANGELOG1,
- ]
- }
- }
-
- dep_file_to_stack_infos = {
- 'src/': {
- 'a.cc': [
- (StackFrame(0, 'src/', 'func', 'a.cc', 'src/a.cc', [1]), 0),
- (StackFrame(1, 'src/', 'func', 'a.cc', 'src/a.cc', [7]), 0),
- ],
- 'b.cc': [
- (StackFrame(2, 'src/', 'func', 'b.cc', 'src/b.cc', [36]), 0),
- ]
- }
- }
-
- dummy_blame = Blame('9', 'a.cc')
- dummy_blame.AddRegion(
- Region(1, 5, '6', 'a', 'a@chromium.org', 'Thu Mar 31 21:24:43 2016'))
- dummy_blame.AddRegion(
- Region(6, 10, '1', 'b', 'b@chromium.org', 'Thu Jun 19 12:11:40 2015'))
-
- def _MockGetBlame(*_):
- return dummy_blame
-
- self.mock(git_repository.GitRepository, 'GetBlame', _MockGetBlame)
-
- stack_deps = {
- 'src/': Dependency('src/', 'https://url_src', 'rev1', 'DEPS'),
- }
-
- expected_match_results = [{
- 'url': 'https://repo.test/+/1',
- 'review_url': 'https://codereview.chromium.org/3281',
- 'revision': '1',
- 'project_path': 'src/',
- 'author': 'r@chromium.org',
- 'time': 'Thu Mar 31 21:24:43 2016',
- 'reasons': None,
- 'confidence': None,
- 'changed_files': None
- }]
-
- match_results = findit_for_crash.FindMatchResults(
- dep_file_to_changelogs, dep_file_to_stack_infos, stack_deps,
- git_repository.GitRepository())
- self.assertEqual([result.ToDict() for result in match_results],
- expected_match_results)
-
- def testFindItForCrashNoRegressionRange(self):
- self.assertEqual(
- findit_for_crash.FindItForCrash(Stacktrace(), {}, {}, 7,
- git_repository.GitRepository()),
- [])
-
- def testFindItForCrashNoMatchFound(self):
-
- def _MockFindMatchResults(*_):
- return []
-
- self.mock(findit_for_crash, 'FindMatchResults', _MockFindMatchResults)
-
- regression_deps_rolls = {'src/': DependencyRoll('src/', 'https://repo',
- '1', '2')}
- self.assertEqual(findit_for_crash.FindItForCrash(
- Stacktrace(), regression_deps_rolls, {}, 7,
- git_repository.GitRepository()), [])
-
- def testFindItForCrash(self):
-
- def _MockFindMatchResults(*_):
- match_result1 = MatchResult(DUMMY_CHANGELOG1, 'src/', '')
- frame1 = StackFrame(0, 'src/', 'func', 'a.cc', 'src/a.cc', [1])
- frame2 = StackFrame(1, 'src/', 'func', 'a.cc', 'src/a.cc', [7])
- match_result1.file_to_stack_infos = {
- 'a.cc': [(frame1, 0), (frame2, 0)]
- }
- match_result1.file_to_analysis_info = {
- 'a.cc': {'min_distance': 0, 'min_distance_frame': frame1}
- }
-
- match_result2 = MatchResult(DUMMY_CHANGELOG3, 'src/', '')
- frame3 = StackFrame(5, 'src/', 'func', 'f.cc', 'src/f.cc', [1])
- match_result2.file_to_stack_infos = {
- 'f.cc': [(frame3, 0)]
- }
- match_result2.file_to_analysis_info = {
- 'a.cc': {'min_distance': 20, 'min_distance_frame': frame3}
- }
-
- return [match_result1, match_result2]
-
- self.mock(findit_for_crash, 'FindMatchResults', _MockFindMatchResults)
-
- expected_match_results = [
- {
- 'reasons': [('TopFrameIndex', 1.0, 'Top frame is #0'),
- ('MinDistance', 1, 'Minimum distance is 0')],
- 'changed_files': [{'info': 'Minimum distance (LOC) 0, frame #0',
- 'blame_url': None, 'file': 'a.cc'}],
- 'time': 'Thu Mar 31 21:24:43 2016',
- 'author': 'r@chromium.org',
- 'url': 'https://repo.test/+/1',
- 'project_path': 'src/',
- 'review_url': 'https://codereview.chromium.org/3281',
- 'confidence': 1.0, 'revision': '1'
- },
- ]
-
- regression_deps_rolls = {'src/': DependencyRoll('src/', 'https://repo',
- '1', '2')}
-
- results = findit_for_crash.FindItForCrash(Stacktrace(),
- regression_deps_rolls, {}, 7,
- git_repository.GitRepository())
- self.assertEqual([result.ToDict() for result in results],
- expected_match_results)
-
- def testFinditForCrashFilterZeroConfidentResults(self):
- def _MockFindMatchResults(*_):
- match_result1 = MatchResult(DUMMY_CHANGELOG1, 'src/', '')
- frame1 = StackFrame(0, 'src/', 'func', 'a.cc', 'src/a.cc', [1])
- frame2 = StackFrame(1, 'src/', 'func', 'a.cc', 'src/a.cc', [7])
- match_result1.file_to_stack_infos = {
- 'a.cc': [(frame1, 0), (frame2, 0)]
- }
- match_result1.file_to_analysis_info = {
- 'a.cc': {'min_distance': 1, 'min_distance_frame': frame1}
- }
-
- match_result2 = MatchResult(DUMMY_CHANGELOG3, 'src/', '')
- frame3 = StackFrame(15, 'src/', 'func', 'f.cc', 'src/f.cc', [1])
- match_result2.file_to_stack_infos = {
- 'f.cc': [(frame3, 0)]
- }
- match_result2.file_to_analysis_info = {
- 'f.cc': {'min_distance': 20, 'min_distance_frame': frame3}
- }
-
- match_result3 = MatchResult(DUMMY_CHANGELOG3, 'src/', '')
- frame4 = StackFrame(3, 'src/', 'func', 'ff.cc', 'src/ff.cc', [1])
- match_result3.file_to_stack_infos = {
- 'f.cc': [(frame4, 0)]
- }
- match_result3.file_to_analysis_info = {
- 'f.cc': {'min_distance': 60, 'min_distance_frame': frame4}
- }
-
- return [match_result1, match_result2, match_result3]
-
- self.mock(findit_for_crash, 'FindMatchResults', _MockFindMatchResults)
-
- expected_match_results = [
- {
- 'author': 'r@chromium.org',
- 'changed_files': [
- {
- 'blame_url': None,
- 'file': 'a.cc',
- 'info': 'Minimum distance (LOC) 1, frame #0'
- }
- ],
- 'confidence': 0.8,
- 'project_path': 'src/',
- 'reasons': [
- ('TopFrameIndex', 1.0, 'Top frame is #0'),
- ('MinDistance', 0.8, 'Minimum distance is 1')
- ],
- 'review_url': 'https://codereview.chromium.org/3281',
- 'revision': '1',
- 'time': 'Thu Mar 31 21:24:43 2016',
- 'url': 'https://repo.test/+/1'
- }
- ]
-
- regression_deps_rolls = {'src/': DependencyRoll('src/', 'https://repo',
- '1', '2')}
-
- results = findit_for_crash.FindItForCrash(Stacktrace(),
- regression_deps_rolls, {}, 7,
- git_repository.GitRepository())
-
- self.assertEqual([result.ToDict() for result in results],
- expected_match_results)
-
- def testFinditForCrashAllMatchResultsWithZeroConfidences(self):
- def _MockFindMatchResults(*_):
- match_result1 = MatchResult(DUMMY_CHANGELOG1, 'src/', '')
- frame1 = StackFrame(20, 'src/', '', 'func', 'a.cc', [1])
- frame2 = StackFrame(21, 'src/', '', 'func', 'a.cc', [7])
- match_result1.file_to_stack_infos = {
- 'a.cc': [(frame1, 0), (frame2, 0)]
- }
- match_result1.file_to_analysis_info = {
- 'a.cc': {'min_distance': 1, 'min_distance_frame': frame1}
- }
-
- match_result2 = MatchResult(DUMMY_CHANGELOG3, 'src/', '')
- frame3 = StackFrame(15, 'src/', '', 'func', 'f.cc', [1])
- match_result2.file_to_stack_infos = {
- 'f.cc': [(frame3, 0)]
- }
- match_result2.min_distance = 20
- match_result2.file_to_analysis_info = {
- 'f.cc': {'min_distance': 20, 'min_distance_frame': frame3}
- }
-
- return [match_result1, match_result2]
-
- self.mock(findit_for_crash, 'FindMatchResults', _MockFindMatchResults)
-
- regression_deps_rolls = {'src/': DependencyRoll('src/', 'https://repo',
- '1', '2')}
-
- self.assertEqual(findit_for_crash.FindItForCrash(
- Stacktrace(), regression_deps_rolls, {}, 7,
- git_repository.GitRepository()), [])
« no previous file with comments | « appengine/findit/crash/test/findit_for_client_test.py ('k') | appengine/findit/crash/test/findit_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698