Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1663)

Unified Diff: appengine/findit/crash/test/classifier_test.py

Issue 2414523002: [Findit] Reorganizing findit_for_*.py (Closed)
Patch Set: Finally fixed the mock tests! Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/crash/test/classifier_test.py
diff --git a/appengine/findit/crash/test/classifier_test.py b/appengine/findit/crash/test/classifier_test.py
deleted file mode 100644
index 782a0c6219b40f2e3c0f1d674868f4194861571e..0000000000000000000000000000000000000000
--- a/appengine/findit/crash/test/classifier_test.py
+++ /dev/null
@@ -1,76 +0,0 @@
-# Copyright 2016 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-from common import constants
-from common.pipeline_wrapper import pipeline_handlers
-from crash.classifier import Occurrence
-from crash.classifier import Classifier
-from crash.classifier import DefaultRankFunction
-from crash.stacktrace import StackFrame
-from crash.stacktrace import CallStack
-from crash.results import Result
-from crash.test.crash_testcase import CrashTestCase
-
-
-class DummyClassifier(Classifier):
-
- def GetClassFromStackFrame(self, frame):
- if frame.dep_path == 'src/':
- return 'class_1'
-
- return 'class_2'
-
- def GetClassFromResult(self, result): # pragma: no cover.
- return 'class_3'
-
- def Classify(self, results, crash_stack):
- class_list = self._Classify(results, crash_stack, 4, 1)
- if class_list:
- return class_list[0]
-
- return ''
-
-
-class ClassifierTest(CrashTestCase):
-
- def testDefaultRankFunction(self):
- self.assertEqual(DefaultRankFunction(Occurrence('c1', [0])),
- (-1, 0))
- self.assertEqual(DefaultRankFunction(Occurrence('c1', [0, 1])),
- (-float('inf'), 0))
-
- def testClassifyCrashStack(self):
- dummy_classifier = DummyClassifier()
-
- crash_stack = CallStack(0)
- self.assertEqual(dummy_classifier.Classify([], crash_stack), '')
-
- crash_stack.extend(
- [StackFrame(0, 'src/', 'a::c(p* &d)', 'f0.cc', 'src/f0.cc', [177]),
- StackFrame(1, 'src/', 'a::d(a* c)', 'f1.cc', 'src/f1.cc', [227]),
- StackFrame(2, 'src/dummy', 'a::e(int)', 'f2.cc', 'src/f2.cc', [87])])
-
- self.assertEqual(dummy_classifier.Classify([], crash_stack), 'class_1')
-
- crash_stack = CallStack(0)
- crash_stack.extend(
- [StackFrame(0, 'src/', 'a::c(p* &d)', 'f0.cc', 'src/f0.cc', [177]),
- StackFrame(1, 'src/dummy', 'a::d(a* c)', 'f1.cc', 'src/f1.cc', [227]),
- StackFrame(2, 'src/dummy', 'a::e(int)', 'f2.cc', 'src/f2.cc', [87])])
-
- self.assertEqual(dummy_classifier.Classify([], crash_stack), 'class_2')
-
- def testClassifyResults(self):
- dummy_classifier = DummyClassifier()
-
- result = Result(self.GetDummyChangeLog(), 'src/')
- result.file_to_stack_infos = {
- 'f0.cc': [(StackFrame(
- 0, 'src/', 'a::c(p* &d)', 'f0.cc', 'src/f0.cc', [177]), 0)]
- }
-
- self.assertEqual(dummy_classifier.Classify([result], CallStack(0)),
- 'class_3')
-
-
« no previous file with comments | « appengine/findit/crash/test/changelist_classifier_test.py ('k') | appengine/findit/crash/test/crash_pipeline_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698