appengine/findit/crash/test/crash_test_suite.py - Issue 2414523002: [Findit] Reorganizing findit_for_*.py

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: appengine/findit/crash/test/crash_test_suite.py

Issue 2414523002: [Findit] Reorganizing findit_for_*.py (Closed)

Patch Set: Finally fixed the mock tests! Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « appengine/findit/crash/test/crash_pipeline_test.py ('k') | appengine/findit/crash/test/detect_regression_range_test.py » ('j') | no next file with comments »

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 from testing_utils import testing	5 from testing_utils import testing

6 from crash.test.stacktrace_test_suite import StacktraceTestSuite	6 from crash.test.stacktrace_test_suite import StacktraceTestSuite

7	7

8	8

9 class CrashTestSuite(StacktraceTestSuite): # pragma: no cover.	9 class CrashTestSuite(StacktraceTestSuite): # pragma: no cover.

10	10

(...skipping 27 matching lines...) Expand all Loading...
38	38

39 self.assertEqual(result1.file_to_analysis_info,	39 self.assertEqual(result1.file_to_analysis_info,

40 result2.file_to_analysis_info)	40 result2.file_to_analysis_info)

41	41

42 def _VerifyTwoMatchResultEqual(self, match_result1, match_result2):	42 def _VerifyTwoMatchResultEqual(self, match_result1, match_result2):

43 self.assertEqual(match_result1.file_to_analysis_info,	43 self.assertEqual(match_result1.file_to_analysis_info,

44 match_result2.file_to_analysis_info)	44 match_result2.file_to_analysis_info)

45 self._VerifyTwoResultEqual(match_result1, match_result2)	45 self._VerifyTwoResultEqual(match_result1, match_result2)

46	46

47 def _VerifyTwoMatchResultsEqual(self, match_results1, match_results2):	47 def _VerifyTwoMatchResultsEqual(self, match_results1, match_results2):

48 self.assertEqual(match_results1.ignore_cls, match_results2.ignore_cls)	48 self.assertEqual(match_results1._ignore_cls, match_results2._ignore_cls)

49	49

50 self.assertEqual(len(match_results1), len(match_results2))	50 self.assertEqual(len(match_results1), len(match_results2))

51 for revision1, match_result1 in match_results1.iteritems():	51 for revision1, match_result1 in match_results1.iteritems():

52 self.assertTrue(revision1 in match_results2)	52 self.assertTrue(revision1 in match_results2)

53 self._VerifyTwoMatchResultEqual(match_result1, match_results2[revision1])	53 self._VerifyTwoMatchResultEqual(match_result1, match_results2[revision1])

OLD	NEW