[Findit] Reorganizing findit_for_*.py

appengine/findit/handlers/crash/crash_handler.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import base64
 import json
 import logging
 
 from common import constants
 from common.base_handler import BaseHandler
@@ skipping 91 matching lines @@
 
       logging.info('Crash data is %s', json.dumps(crash_data))
 
       crash_pipeline.ScheduleNewAnalysisForCrash(
           crash_data['crash_identifiers'],
           crash_data['chrome_version'],
           crash_data['signature'],
           crash_data['client_id'],
           crash_data['platform'],
           crash_data['stack_trace'],
-          crash_data['customized_data'],
+          crash_data['customized_data']['channel'],

[Sharu Jiang, 2016/10/12 17:46:29]

? This is not correct, the 'historical_metadata' got discarded.

[wrengr, 2016/10/12 21:14:51]

ScheduleNewAnalysisForCrash (the version in this CL, at least) doesn't use the
historical_metadata, it only uses the channel; hence passing it directly rather
than bundling it up in a dict.

[Sharu Jiang, 2016/10/12 22:35:03]

The function is to schedule analysis for any client, however the 'channel' is
fracas/cracas-specific. We should pass in the 'customized_data' and handle it
accordingly.

[wrengr, 2016/10/18 23:13:54]

As mentioned elsewhere, I mislike having this 'customized_data' thing, because
it's very underspecified what exactly it's supposed to be. Since we presently
don't support Clusterfuzz, passing a ChromeCrash-specific thing isn't a problem
yet. I agree things should be cleaned up in the future, but that's outside of
the scope of the current CL.

           queue_name=constants.CRASH_ANALYSIS_QUEUE[crash_data['client_id']])
     except (KeyError, ValueError):  # pragma: no cover.
       # TODO: save exception in datastore and create a page to show them.
       logging.exception('Failed to process crash message')
       logging.info(self.request.body)