[Findit] Reorganizing findit_for_*.py

appengine/findit/handlers/crash/crash_handler.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import base64
 import json
 import logging
 
 from common import constants
 from common.base_handler import BaseHandler
 from common.base_handler import Permission
-from crash import crash_pipeline
+from crash import findit_for_chromecrash
+from crash import findit_for_clusterfuzz
+from crash.crash_report import CrashReport
+from crash.type_enums import CrashClient
+
+
+# TODO(wrengr): we'd like to move this to findit.py (or somewhere similar)
+# so it's encapsulated along with the Findit classes; but to do that we'd
+# need to merge findit.py and findit_for_chromecrash.py to avoid cyclic
+# dependencies. Is there a clean way to do what we want?
+def FinditForClientID(client_id):
+  if client_id == CrashClient.FRACAS:
+    return findit_for_chromecrash.FinditForFracas()
+  elif client_id == CrashClient.CRACAS:
+    return findit_for_chromecrash.FinditForCracas()
+  elif client_id == CrashClient.CLUSTERFUZZ:
+    return findit_for_clusterfuzz.FinditForClusterfuzz()
+  else:
+    logging.info('Client %s is not supported by findit right now', client_id)
+    raise ValueError()
 
 
 class CrashHandler(BaseHandler):
   PERMISSION_LEVEL = Permission.ANYONE
 
   def HandlePost(self):
     """Handles push delivery from Pub/Sub for crash data.
 
     The crash data should be in the following json format:
     {
@@ skipping 72 matching lines @@
       received_message = json.loads(self.request.body)
       pubsub_message = received_message['message']
       crash_data = json.loads(base64.b64decode(pubsub_message['data']))
 
       logging.info('Processing message %s from subscription %s.',
                    pubsub_message['message_id'],
                    received_message['subscription'])
 
       logging.info('Crash data is %s', json.dumps(crash_data))
 
-      crash_pipeline.ScheduleNewAnalysisForCrash(
-          crash_data['crash_identifiers'],
-          crash_data['chrome_version'],
-          crash_data['signature'],
-          crash_data['client_id'],
-          crash_data['platform'],
-          crash_data['stack_trace'],
-          crash_data['customized_data'],
-          queue_name=constants.CRASH_ANALYSIS_QUEUE[crash_data['client_id']])
+      client_id = crash_data['client_id']
+      FinditForClientID(client_id).ScheduleNewAnalysis(crash_data,
+          queue_name=constants.CRASH_ANALYSIS_QUEUE[client_id])
     except (KeyError, ValueError):  # pragma: no cover.
       # TODO: save exception in datastore and create a page to show them.
       logging.exception('Failed to process crash message')
       logging.info(self.request.body)