Issue 24145011: Flush recompile jobs on last-resort GC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24145011: Flush recompile jobs on last-resort GC. (Closed)

Created:
7 years, 3 months ago by Yang

Modified:
7 years, 3 months ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Flush recompile jobs on last-resort GC. R=hpayer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16922

Patch Set 3 : addressed comments #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	src/heap.cc	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Hannes Payer (out of office)

LGTM, one nit https://codereview.chromium.org/24145011/diff/4001/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/24145011/diff/4001/src/heap.cc#newcode612 src/heap.cc:612: // The optimizing compiler may be ...

7 years, 3 months ago (2013-09-24 13:28:07 UTC) #2

Yang

7 years, 3 months ago (2013-09-24 13:39:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r16922 (presubmit successful).

Expand Messages | Collapse Messages

Issue 24145011: Flush recompile jobs on last-resort GC. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : addressed comments #

Messages